Bugzilla – Attachment 73244 Details for
Bug 20420
Remove unnecessary [% KOHA_VERSION %] from OPAC third-party sources
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20420: Remove unnecessary [% KOHA_VERSION %] from OPAC third-party sources
Bug-20420-Remove-unnecessary--KOHAVERSION--from-OP.patch (text/plain), 3.32 KB, created by
Katrin Fischer
on 2018-03-25 16:03:11 UTC
(
hide
)
Description:
Bug 20420: Remove unnecessary [% KOHA_VERSION %] from OPAC third-party sources
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2018-03-25 16:03:11 UTC
Size:
3.32 KB
patch
obsolete
>From 02c7791f5ab9024d14c1828d635e417eedc9a0e2 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 15 Mar 2018 10:34:26 +0000 >Subject: [PATCH] Bug 20420: Remove unnecessary [% KOHA_VERSION %] from OPAC > third-party sources > >This patch removes [% KOHA_VERSION %] from the <script> tag for some >third-party JavaScript sources. [% KOHA_VERSION %] should only be used >for Koha's JS resources. > >To test, apply the patch and enable the SocialNetworks and >NovelistSelect* preferences. > >In the OPAC, view the detail page for a bibliographic record. In the >right-hand sidebar you should see social network icons for Google+ and >Twitter. Clicking either of them should trigger a sharing popup window. > >If you have Novelist credentials and can enable the feature for the OPAC >you should see Novelist content in the place specified in your >preferences. > >If you don't have Novelist credentials, put some random text in the >NovelistSelectProfile system preference. Looking at the detail page in >the OPAC, view source. You should see a link to Novelist JS around line >1020 of the source. Clicking the link should show JavaScript. This >confirms that the path is correct, thus the bug has been fixed. > >Note: The QA tool will complain that [% KOHA_VERSION %] is missing. This >is a false positive. > >Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 4801f90..c688a3f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -1179,7 +1179,7 @@ > [% END %] > > [% IF ( NovelistSelectProfile && normalized_isbn ) %] >- <script type="text/javascript" src="https://imageserver.ebscohost.com/novelistselect/ns2init_[% KOHA_VERSION %].js"></script> >+ <script type="text/javascript" src="https://imageserver.ebscohost.com/novelistselect/ns2init.js"></script> > [% END %] > > [% IF ( Babeltheque ) %] >@@ -1393,12 +1393,12 @@ > [% INCLUDE 'datatables.inc' %] > [% INCLUDE 'columns_settings.inc' %] > [% IF ( SocialNetworks ) %] >- <script type="text/javascript" src="https://apis.google.com/js/plusone_[% KOHA_VERSION %].js"> >+ <script type="text/javascript" src="https://apis.google.com/js/plusone.js"> > //<![CDATA[ > {lang: '[% lang %]'} > //]]> > </script> >- <script type="text/javascript">!function(d,s,id){var js,fjs=d.getElementsByTagName(s)[0];if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src="//platform.twitter.com/widgets_[% KOHA_VERSION %].js";fjs.parentNode.insertBefore(js,fjs);}}(document,"script","twitter-wjs");</script> >+ <script type="text/javascript">!function(d,s,id){var js,fjs=d.getElementsByTagName(s)[0];if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src="//platform.twitter.com/widgets.js";fjs.parentNode.insertBefore(js,fjs);}}(document,"script","twitter-wjs");</script> > [% END %] > [% IF ( OpacStarRatings != 'disable' ) %]<script type="text/javascript" src="[% interface %]/[% theme %]/lib/jquery/plugins/jquery.rating_[% KOHA_VERSION %].js"></script>[% END %] > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20420
:
72927
|
72964
|
73243
| 73244