Attachment 73286 Details for Bug 20330 – Bug 20330: Allow translating more of quote upload

[patch] Bug 20330: Allow translating more of quote upload

Bug-20330-Allow-translating-more-of-quote-upload.patch (text/plain), 2.93 KB, created by Mark Tompsett on 2018-03-26 15:26:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2018-03-26 15:26:22 UTC

Size: 2.93 KB

patch

obsolete

>From 93154e064f302470b2762c26be6a2b724fa3e34e Mon Sep 17 00:00:00 2001
>From: Pasi Kallinen <pasi.kallinen@joensuu.fi>
>Date: Mon, 5 Mar 2018 09:09:28 +0200
>Subject: [PATCH] Bug 20330: Allow translating more of quote upload
>
>Translate the error messages, and the table headers.
>
>Test plan:
>
>1) Go to Home -> Tools -> Quote editor -> Import quotes
>2) Upload quotes from a file. Try to trigger the error messages
>3) On successful import, check the table header texts
>4) Apply patch, update & install a language
>5) The error messages and the table header texts should
>   show up in the xx-YY-staff-prog.po
>6) Repeat 1,2,3
>
>Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi>
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>---
> .../intranet-tmpl/prog/en/modules/tools/quotes-upload.tt   | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes-upload.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes-upload.tt
>index 3eb0ee5..9840e86 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes-upload.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes-upload.tt
>@@ -109,15 +109,15 @@
>         function fnErrorHandler(evt) {
>             switch(evt.target.error.code) {
>                 case evt.target.error.NOT_FOUND_ERR:
>-                    alert('File Not Found!');
>+                    alert(_("File Not Found!"));
>                     break;
>                 case evt.target.error.NOT_READABLE_ERR:
>-                    alert('File is not readable');
>+                    alert(_("File is not readable"));
>                     break;
>                 case evt.target.error.ABORT_ERR:
>                     break; // noop
>                 default:
>-                    alert('An error occurred reading this file.');
>+                    alert(_("An error occurred reading this file."));
>             };
>         }
> 
>@@ -237,15 +237,15 @@
>                 "aaData"            : aaData,
>                 "aoColumns"         : [
>                     {
>-                        "sTitle"  : "Number",
>+                        "sTitle"  : _("Number"),
>                         "sWidth"  : "2%",
>                     },
>                     {
>-                        "sTitle"  : "Source",
>+                        "sTitle"  : _("Source"),
>                         "sWidth"  : "15%",
>                     },
>                     {
>-                        "sTitle"  : "Quote",
>+                        "sTitle"  : _("Quote"),
>                         "sWidth"  : "83%",
>                     },
>                 ],
>@@ -292,7 +292,7 @@
>             reader.onerror = fnErrorHandler;
>             reader.onprogress = fnUpdateProgress;
>             reader.onabort = function(e) {
>-                alert('File read cancelled');
>+                alert(_("File read cancelled"));
>                 parent.location='quotes-upload.pl';
>             };
>             reader.onloadstart = function(e) {
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 20330: 72405 | 73286 | 73357