Bugzilla – Attachment 73297 Details for
Bug 20462
Duplicate barcodes in batch item deletion cause software error if deleting biblio records
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20462: Ensure batch item deletion will not delete the same item twice
Bug-20462-Ensure-batch-item-deletion-will-not-dele.patch (text/plain), 1.68 KB, created by
Mark Tompsett
on 2018-03-26 23:09:29 UTC
(
hide
)
Description:
Bug 20462: Ensure batch item deletion will not delete the same item twice
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2018-03-26 23:09:29 UTC
Size:
1.68 KB
patch
obsolete
>From 1eab9fe2a2abf1dbf4c3aab5f6a897a89643b383 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 26 Mar 2018 12:22:15 -0300 >Subject: [PATCH] Bug 20462: Ensure batch item deletion will not delete the > same item twice >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This has been done on bug 9509 when barcodes are scaned, but not when using a text file. > >Test plan (stolen from Barton on the bug report): >1) Create a text file containing duplicate barcodes > >Here's a quick way to do that, substitute INSTANCE for the instance name of your test server: > >sudo koha-mysql INSTANCE <<< "select barcode from items where barcode is not null limit 3" | sed '1d;p' > /tmp/dup_barcodes.txt > >2) Go to Home ⺠Tools ⺠Batch item deletion >3) Click 'Choose File', select the file you created in step 1. >4) Click 'Continue' >5) Note that duplicate items appear in the list of items to batch delete >6) Check 'Delete records if no items remain' >7) This will trigger a software error > >Note that entering the barcodes via the 'scan items one by one' text box removes duplicates in the list, so this only causes problems when uploading a file. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >--- > tools/batchMod.pl | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/tools/batchMod.pl b/tools/batchMod.pl >index 5f54076..94062f7 100755 >--- a/tools/batchMod.pl >+++ b/tools/batchMod.pl >@@ -242,6 +242,7 @@ if ($op eq "show"){ > push @contentlist, $content if $content; > } > >+ @contentlist = uniq @contentlist; > if ($filecontent eq 'barcode_file') { > foreach my $barcode (@contentlist) { > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20462
:
73285
|
73297
|
73411