Bugzilla – Attachment 73317 Details for
Bug 18382
action_logs entry for module HOLDS, action SUSPEND is spammy
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18382 [QA Followup]: Don't set suspend_until if dt if undefined
Bug-18382-QA-Followup-Dont-set-suspenduntil-if-dt-.patch (text/plain), 831 bytes, created by
Kyle M Hall (khall)
on 2018-03-27 14:45:41 UTC
(
hide
)
Description:
Bug 18382 [QA Followup]: Don't set suspend_until if dt if undefined
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2018-03-27 14:45:41 UTC
Size:
831 bytes
patch
obsolete
>From 65ccd0a123d46a5b91496e715262357379668f49 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatetsolutions.com> >Date: Tue, 27 Mar 2018 10:45:09 -0400 >Subject: [PATCH] Bug 18382 [QA Followup]: Don't set suspend_until if dt if > undefined > >--- > Koha/Hold.pm | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > >diff --git a/Koha/Hold.pm b/Koha/Hold.pm >index acb5adedb0..e76b9fb17e 100644 >--- a/Koha/Hold.pm >+++ b/Koha/Hold.pm >@@ -91,11 +91,7 @@ sub suspend_hold { > } > > $self->suspend(1); >- if ( defined $dt ){ >- $self->suspend_until( $dt->datetime ); >- } else { >- $self->suspend_until( $dt ); >- } >+ $self->suspend_until( $dt->datetime ) if ( defined $dt ); > $self->store(); > > logaction( 'HOLDS', 'SUSPEND', $self->reserve_id, Dumper($self->unblessed) ) >-- >2.14.3 (Apple Git-98)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18382
:
61842
|
63962
|
68281
|
68363
|
68364
|
72610
|
73149
|
73150
| 73317 |
73343
|
73420