Bugzilla – Attachment 73420 Details for
Bug 18382
action_logs entry for module HOLDS, action SUSPEND is spammy
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18382 [QA Followup]: Make new unit test pass
Bug-18382-QA-Followup-Make-new-unit-test-pass.patch (text/plain), 1.07 KB, created by
Kyle M Hall (khall)
on 2018-03-29 12:01:02 UTC
(
hide
)
Description:
Bug 18382 [QA Followup]: Make new unit test pass
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2018-03-29 12:01:02 UTC
Size:
1.07 KB
patch
obsolete
>From 9dc705c19e3e68979d6d2db08226917a0bad072a Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 28 Mar 2018 19:58:37 +0000 >Subject: [PATCH] Bug 18382 [QA Followup]: Make new unit test pass > >--- > Koha/Hold.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/Hold.pm b/Koha/Hold.pm >index e76b9fb17e..afdafb8028 100644 >--- a/Koha/Hold.pm >+++ b/Koha/Hold.pm >@@ -83,7 +83,7 @@ my $hold = $hold->suspend_hold( $suspend_until_dt ); > sub suspend_hold { > my ( $self, $dt ) = @_; > >- $dt = $dt ? $dt->clone()->truncate( to => 'day' ) : undef; >+ my $date = $dt ? $dt->clone()->truncate( to => 'day' )->datetime : undef; > > if ( $self->is_waiting ) { # We can't suspend waiting holds > carp "Unable to suspend waiting hold!"; >@@ -91,7 +91,7 @@ sub suspend_hold { > } > > $self->suspend(1); >- $self->suspend_until( $dt->datetime ) if ( defined $dt ); >+ $self->suspend_until( $date ); > $self->store(); > > logaction( 'HOLDS', 'SUSPEND', $self->reserve_id, Dumper($self->unblessed) ) >-- >2.14.3 (Apple Git-98)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18382
:
61842
|
63962
|
68281
|
68363
|
68364
|
72610
|
73149
|
73150
|
73317
|
73343
| 73420