Attachment 73422 Details for Bug 20052 – Bug 20052: (follow-up) Fix QA tool complaints and bad copy

[patch] Bug 20052: (follow-up) Fix QA tool complaints and bad copy

Bug-20052-follow-up-Fix-QA-tool-complaints-and-bad.patch (text/plain), 1.49 KB, created by Nick Clemens (kidclamp) on 2018-03-29 13:04:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2018-03-29 13:04:14 UTC

Size: 1.49 KB

patch

obsolete

>From 3ab94494930f49ec765002b8850e267650177964 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Thu, 29 Mar 2018 13:00:36 +0000
>Subject: [PATCH] Bug 20052: (follow-up) Fix QA tool complaints and bad copy
>
>---
> Koha/Report.pm                |  4 +++-
> Koha/Reports.pm               | 10 +++++++++-
> t/db_dependent/Koha/Reports.t |  2 --
> 3 files changed, 12 insertions(+), 4 deletions(-)
>
>diff --git a/Koha/Report.pm b/Koha/Report.pm
>index a4b540d..3be4415 100644
>--- a/Koha/Report.pm
>+++ b/Koha/Report.pm
>@@ -33,7 +33,9 @@ Koha::Report - Koha Report Object class
> 
> =cut
> 
>-=head3 type
>+=head3 _type
>+
>+Returns name of corresponding DBIC resultset
> 
> =cut
> 
>diff --git a/Koha/Reports.pm b/Koha/Reports.pm
>index c0715ae..ca687a3 100644
>--- a/Koha/Reports.pm
>+++ b/Koha/Reports.pm
>@@ -35,7 +35,9 @@ Koha::Reports - Koha Report Object set class
> 
> =cut
> 
>-=head3 type
>+=head3 _type
>+
>+Returns name of corresponding DBIC resultset
> 
> =cut
> 
>@@ -43,6 +45,12 @@ sub _type {
>     return 'SavedSql';
> }
> 
>+=head3 object_class
>+
>+Returns name of corresponding Koha Object Class
>+
>+=cut
>+
> sub object_class {
>     return 'Koha::Report';
> }
>diff --git a/t/db_dependent/Koha/Reports.t b/t/db_dependent/Koha/Reports.t
>index 4948e12..45c5662 100644
>--- a/t/db_dependent/Koha/Reports.t
>+++ b/t/db_dependent/Koha/Reports.t
>@@ -1,7 +1,5 @@
> #!/usr/bin/perl
> 
>-# Copyright 2015 Koha Development team
>-#
> # This file is part of Koha
> #
> # Koha is free software; you can redistribute it and/or modify it
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 20052: 70784 | 70845 | 72386 | 73422 | 73455 | 73456