Attachment 73441 Details for Bug 20494 – Bug 20494 - Remove unused code in neworderempty.pl and addbiblio.pl

[patch] Bug 20494 - Remove unused code in neworderempty.pl and addbiblio.pl

Bug-20494---Remove-unused-code-in-neworderemptypl-.patch (text/plain), 4.27 KB, created by Mark Tompsett on 2018-03-29 18:58:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2018-03-29 18:58:51 UTC

Size: 4.27 KB

patch

obsolete

>From 193545d0f0129d617596769942738650987f8929 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Thu, 29 Mar 2018 12:33:56 +0000
>Subject: [PATCH] Bug 20494 - Remove unused code in neworderempty.pl and
> addbiblio.pl
>
>Should be sufficient to read code and see all lines were commented and
>that this patch removes useless lines
>
>To be thorough, ensure that your can add an order to a basket and add a
>biblio.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>---
> acqui/neworderempty.pl   | 6 ------
> cataloguing/addbiblio.pl | 6 ------
> 2 files changed, 12 deletions(-)
>
>diff --git a/acqui/neworderempty.pl b/acqui/neworderempty.pl
>index 680be6a..e9dcc2d 100755
>--- a/acqui/neworderempty.pl
>+++ b/acqui/neworderempty.pl
>@@ -418,7 +418,6 @@ sub MARCfindbreeding {
>             {
>                 my ( $tag, $subfield ) = GetMarcFromKohaField("biblio.author", '');
> 
>-#                 my $summary = C4::Context->preference("z3950authortemplate");
>                 my $auth_fields =
>                 C4::Context->preference("z3950AuthorAuthFields");
>                 my @auth_fields = split /,/, $auth_fields;
>@@ -427,7 +426,6 @@ sub MARCfindbreeding {
>                 if ( $record->field($tag) ) {
>                     foreach my $tmpfield ( $record->field($tag)->subfields ) {
> 
>-    #                        foreach my $subfieldcode ($tmpfield->subfields){
>                         my $subfieldcode  = shift @$tmpfield;
>                         my $subfieldvalue = shift @$tmpfield;
>                         if ($field) {
>@@ -451,16 +449,12 @@ sub MARCfindbreeding {
>                     my $title     = $record->field($fieldtag)->subfield('c');
>                     my $number    = $record->field($fieldtag)->subfield('d');
>                     if ($title) {
>-
>-#                         $field->add_subfields("$subfield"=>"[ ".ucfirst($title).ucfirst($firstname)." ".$number." ]");
>                         $field->add_subfields(
>                                 "$subfield" => ucfirst($title) . " "
>                             . ucfirst($firstname) . " "
>                             . $number );
>                     }
>                     else {
>-
>-#                       $field->add_subfields("$subfield"=>"[ ".ucfirst($firstname).", ".ucfirst($lastname)." ]");
>                         $field->add_subfields(
>                             "$subfield" => ucfirst($firstname) . ", "
>                             . ucfirst($lastname) );
>diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl
>index 17557b4..4ecaf69 100755
>--- a/cataloguing/addbiblio.pl
>+++ b/cataloguing/addbiblio.pl
>@@ -107,7 +107,6 @@ sub MARCfindbreeding {
>             {
>                 my ( $tag, $subfield ) = GetMarcFromKohaField("biblio.author", '');
> 
>- #                 my $summary = C4::Context->preference("z3950authortemplate");
>                 my $auth_fields =
>                   C4::Context->preference("z3950AuthorAuthFields");
>                 my @auth_fields = split /,/, $auth_fields;
>@@ -116,7 +115,6 @@ sub MARCfindbreeding {
>                 if ( $record->field($tag) ) {
>                     foreach my $tmpfield ( $record->field($tag)->subfields ) {
> 
>-       #                        foreach my $subfieldcode ($tmpfield->subfields){
>                         my $subfieldcode  = shift @$tmpfield;
>                         my $subfieldvalue = shift @$tmpfield;
>                         if ($field) {
>@@ -140,16 +138,12 @@ sub MARCfindbreeding {
>                     my $title     = $record->field($fieldtag)->subfield('c');
>                     my $number    = $record->field($fieldtag)->subfield('d');
>                     if ($title) {
>-
>-#                         $field->add_subfields("$subfield"=>"[ ".ucfirst($title).ucfirst($firstname)." ".$number." ]");
>                         $field->add_subfields(
>                                 "$subfield" => ucfirst($title) . " "
>                               . ucfirst($firstname) . " "
>                               . $number );
>                     }
>                     else {
>-
>-#                       $field->add_subfields("$subfield"=>"[ ".ucfirst($firstname).", ".ucfirst($lastname)." ]");
>                         $field->add_subfields(
>                             "$subfield" => ucfirst($firstname) . ", "
>                               . ucfirst($lastname) );
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 20494: 73421 | 73441 | 73454