Attachment 73457 Details for Bug 19907 – Bug 19907: Fix email validation in patron edit form

[patch] Bug 19907: Fix email validation in patron edit form

Bug-19907-Fix-email-validation-in-patron-edit-form.patch (text/plain), 2.17 KB, created by Josef Moravec on 2018-03-30 09:42:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2018-03-30 09:42:16 UTC

Size: 2.17 KB

patch

obsolete

>From bff6bde43ee402edd9e06238b88423b2430a0fee Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Wed, 3 Jan 2018 11:20:46 +0000
>Subject: [PATCH] Bug 19907: Fix email validation in patron edit form
>
>Test plan:
>0) Confirm that email validation is not working in add/edit patron form
>1) Apply the patch
>2) Edit/add patron, the e-mail validation should be working now
>3) Ensure the password validation is still working (use test plan from
>    bug 19908)
>---
> .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt  | 12 ------------
> koha-tmpl/intranet-tmpl/prog/js/members.js                   |  7 +++++++
> 2 files changed, 7 insertions(+), 12 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>index a70a645..4309824 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>@@ -1245,18 +1245,6 @@
>                 else {return false;}
>             });
> 
>-            $("#entryform").validate({
>-                rules: {
>-                    password: {
>-                        password_strong: true,
>-                        password_no_spaces: true
>-                    },
>-                    password2: {
>-                        password_match: true
>-                    }
>-                }
>-            });
>-
>             $("#saverecord").click(function(){
>                 if( check_form_borrowers() ){
>                     $("#entryform").submit();
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/members.js b/koha-tmpl/intranet-tmpl/prog/js/members.js
>index aea1f68..e586e60 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/members.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/members.js
>@@ -319,6 +319,13 @@ $(document).ready(function(){
>             },
>             B_email: {
>                 email: true
>+            },
>+            password: {
>+               password_strong: true,
>+               password_no_spaces: true
>+            },
>+            password2: {
>+               password_match: true
>             }
>         },
>         submitHandler: function(form) {
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 19907: 70244 | 73457 | 73459 | 73463