Attachment 73500 Details for Bug 12502 – Bug 12502 - Add ordernumber and ISBN to late order

[patch] Bug 12502 - Add ordernumber and ISBN to late order

Bug-12502---Add-ordernumber-and-ISBN-to-late-order.patch (text/plain), 3.27 KB, created by Charles Farmer on 2018-03-30 20:36:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Charles Farmer

Created: 2018-03-30 20:36:07 UTC

Size: 3.27 KB

patch

obsolete

>From b7a97dd7615b85c595a17e99db6f8d881d8bab27 Mon Sep 17 00:00:00 2001
>From: David Bourgault <david.bourgault@inlibro.com>
>Date: Mon, 25 Sep 2017 15:30:50 -0400
>Subject: [PATCH] Bug 12502 - Add ordernumber and ISBN to late order
>
>Adds ordernumber as 2nd column and ISBN as last
>
>Followed test plan and patch worked as described. Also ran QA test tools
>and all modified files passed
>
>Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
>---
> C4/Acquisition.pm                                           |  3 ++-
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt | 10 ++++++++--
> 2 files changed, 10 insertions(+), 3 deletions(-)
>
>diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm
>index e1a71c6..c854c1a 100644
>--- a/C4/Acquisition.pm
>+++ b/C4/Acquisition.pm
>@@ -2137,7 +2137,7 @@ sub GetLateOrders {
>     my @query_params = ();
>     my $select = "
>     SELECT aqbasket.basketno,
>-        aqorders.ordernumber,
>+        aqorders.ordernumber      AS ordernumber,
>         DATE(aqbasket.closedate)  AS orderdate,
>         aqbasket.basketname       AS basketname,
>         aqbasket.basketgroupid    AS basketgroupid,
>@@ -2155,6 +2155,7 @@ sub GetLateOrders {
>         biblio.author, biblio.title,
>         biblioitems.publishercode AS publisher,
>         biblioitems.publicationyear,
>+        biblioitems.isbn          AS isbn,
>         ADDDATE(aqbasket.closedate, INTERVAL aqbooksellers.deliverytime DAY) AS estimateddeliverydate,
>     ";
>     my $from = "
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt
>index b6d139e..d53ca20 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt
>@@ -56,6 +56,7 @@
>             [% ELSE %]
>                 <th></th>
>             [% END %]
>+            <th>Order No.</th>
>             <th class="title-string">Order date</th>
>             <th class="title-string">Estimated delivery date</th>
>             <th>Vendor</th>
>@@ -69,6 +70,7 @@
>             <th class="title-string">Claimed date</th>
>             <th>Internal note</th>
>             <th>Vendor note</th>
>+            <th>ISBN</th>
>         </tr>
>       </thead>
>       <tbody>
>@@ -78,6 +80,9 @@
>                 <input type="checkbox" value="[% lateorder.ordernumber %]" data-booksellerid="[% lateorder.supplierid %]" name="ordernumber">
>             </td>
>             <td>
>+                [% lateorder.ordernumber %]
>+            </td>
>+            <td>
>                 <span title="[% lateorder.orderdate %]">[% lateorder.orderdate | $KohaDates %] ([% lateorder.latesince %] days)</span>
>             </td>
>             <td>
>@@ -135,14 +140,15 @@
>             </td>
>             <td><input name="internalnote" id="internalnote" type="text" value="[% lateorder.internalnote %]"></td>
>             <td><input name="vendornote" id="vendornote" type="text" value="[% lateorder.vendornote %]"></td>
>+            <td>[% lateorder.isbn %]</td>
>         </tr>
>       [% END %]
>       </tbody>
>       <tfoot>
>         <tr>
>-            <th colspan="5">Total</th>
>+            <th colspan="6">Total</th>
>             <th>[% total %]</th>
>-            <th colspan="8">&nbsp;</th>
>+            <th colspan="9">&nbsp;</th>
>         </tr>
>       </tfoot>
>     </table>
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 12502: 67349 | 67354 | 67586 | 67587 | 72168 | 72169 | 72170 | 73499 | 73500 | 73501 | 73502 | 73503 | 79231 | 80160 | 80602 | 87236 | 91564 | 95418 | 95419 | 95438 | 95439 | 95440 | 95441 | 97427 | 97428 | 97429 | 97430