Bugzilla – Attachment 73514 Details for
Bug 18799
XSLTresultsdisplay hides the icons
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18799 [ Alternate ] XSLTresultsdisplay hides the icons
Bug-18799--Alternate--XSLTresultsdisplay-hides-the.patch (text/plain), 4.77 KB, created by
Victor Grousset/tuxayo
on 2018-03-31 18:52:57 UTC
(
hide
)
Description:
Bug 18799 [ Alternate ] XSLTresultsdisplay hides the icons
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2018-03-31 18:52:57 UTC
Size:
4.77 KB
patch
obsolete
>From b7010ffe381b7a80d268391d8bee7d5a6feefb42 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 15 Jun 2017 12:32:43 +0000 >Subject: [PATCH] Bug 18799 [ Alternate ] XSLTresultsdisplay hides the icons > >If item-level_itypes is turned off and XSLTResultsDisplay is turned on, >biblio-level itemtype images are not shown in staff client search >results. This patch corrects the problem. > >This patch also adds some markup and CSS to the itemtype image to make >it look a litte cleaner and work better in result sets in which some >titles have images and some don't. > >To test, apply the patch and view the staff client search results page >with various settings: > >- XSLT turned on and off >- item-level_itypes turned on and off >- noItemTypeImages turned on and off > >Confirm that item type images are shown or not shown correctly according >to each setting. > >The difference between this patch and the other patch currently on this >bug is that this patch continues the practice of hiding biblio-level >itemtype information when item-level_itypes is ON. >--- > koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 14 ++++++++++++ > .../prog/en/modules/catalogue/results.tt | 25 ++++++++++------------ > 2 files changed, 25 insertions(+), 14 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/css/staff-global.css >index 32a614b..062d844 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/staff-global.css >+++ b/koha-tmpl/intranet-tmpl/prog/css/staff-global.css >@@ -3218,3 +3218,17 @@ span.name { > font-weight: bold; > font-style: italic; > } >+ >+.result-biblio-itemtype { >+ float: right; >+ padding: .5em; >+ margin: .5em; >+ font-size: 85%; >+ text-align: center; >+} >+ >+.result-biblio-itemtype img { >+ display: block; >+ margin: auto; >+ margin-bottom: 2px; >+} >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >index 459bc08..c029646 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >@@ -382,6 +382,16 @@ > <input type="checkbox" class="selection" id="bib[% SEARCH_RESULT.biblionumber %]" name="biblionumber" value="[% SEARCH_RESULT.biblionumber %]" style="display:none" /> > </td> > <td> >+ >+ [% UNLESS ( item_level_itypes ) %] >+ <div class="result-biblio-itemtype"> >+ [% IF !noItemTypeImages && SEARCH_RESULT.imageurl %] >+ <img src="[% SEARCH_RESULT.imageurl %]" alt="[% SEARCH_RESULT.description %]" /> >+ [% END %] >+ [% SEARCH_RESULT.description %] >+ </div> >+ [% END %] >+ > [% IF ( SEARCH_RESULT.XSLTResultsRecord ) %] > [% SEARCH_RESULT.result_number %]. > [% SEARCH_RESULT.XSLTResultsRecord %] >@@ -402,22 +412,9 @@ > [% ELSE %] > > [% END %] >- <p> >- [% UNLESS ( item_level_itypes ) %] >- [% IF !noItemTypeImages && SEARCH_RESULT.imageurl %] >- <img src="[% SEARCH_RESULT.imageurl %]" title="[% SEARCH_RESULT.description %]" style="float: left; margin: .1em;" alt="[% SEARCH_RESULT.description %]" /> >- [% END %] >- [% SEARCH_RESULT.description %] >- [% END %] >- [% SEARCH_RESULT.summary %]</p> >+ <p>[% SEARCH_RESULT.summary %]</p> > [% ELSE %] > <p> >- [% UNLESS ( item_level_itypes ) %] >- [% IF !noItemTypeImages && SEARCH_RESULT.imageurl %] >- <img src="[% SEARCH_RESULT.imageurl %]" title="[% SEARCH_RESULT.description %]" style="float: left; margin: .1em;" alt="" /> >- [% END %] >- [% END %] >- > [% IF ( SEARCH_RESULT.author ) %] > <a href="/cgi-bin/koha/catalogue/search.pl?idx=au&q=[% SEARCH_RESULT.author |url %]" title="Search for this Author">[% SEARCH_RESULT.author %]</a> > [% ELSE %] >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18799
:
64276
|
64277
|
64279
|
64327
|
64728
|
73514
|
74417
|
74609