Bugzilla – Attachment 73518 Details for
Bug 19910
Download report as 'Comma separated' is misleading
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19910 - Use the delimiter syspref to name download link
Bug-19910---Use-the-delimiter-syspref-to-name-down.patch (text/plain), 3.12 KB, created by
Victor Grousset/tuxayo
on 2018-04-01 15:55:55 UTC
(
hide
)
Description:
Bug 19910 - Use the delimiter syspref to name download link
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2018-04-01 15:55:55 UTC
Size:
3.12 KB
patch
obsolete
>From 11bfc2d05ea8234de2e48e36092f71dd198acdc4 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 3 Jan 2018 14:07:17 +0000 >Subject: [PATCH] Bug 19910 - Use the delimiter syspref to name download link > >To test: >1 - Set delimiter syspref to anything but comma >2 - Download report results as comma separated text >3 - They actually follow the syspref >4 - Apply patch >5 - Download link should now match pref selection >6 - Change pref, note link changes >7 - Verify things still work as expected > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Victor Grousset <victor.grousset@biblibre.com> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/delimiter_text.inc | 8 ++++++++ > koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc | 3 ++- > 2 files changed, 10 insertions(+), 1 deletion(-) > create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/delimiter_text.inc > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/delimiter_text.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/delimiter_text.inc >new file mode 100644 >index 0000000..e6b4aca >--- /dev/null >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/delimiter_text.inc >@@ -0,0 +1,8 @@ >+[% SWITCH Koha.Preference('delimiter') %] >+ [% CASE '#' %]Pound (#) separated text (.csv) >+ [% CASE ',' %]Comma separated text (.csv) >+ [% CASE '/' %]Slash separated text (.csv) >+ [% CASE ';' %]Semicolon separated text (.csv) >+ [% CASE '\\' %]Backslash separated text (.csv) >+ [% CASE 'tabulation' %]Tab separated text (.csv) >+[% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc >index 649fbe1..9b3a562 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc >@@ -52,10 +52,11 @@ > [%- FOREACH param IN sql_params %]&sql_params=[% param %][% END %] > [%- END %] > >+ > <div class="btn-group"> > <button class="btn btn-default btn-sm dropdown-toggle" data-toggle="dropdown" id="format"><i class="fa fa-upload"></i> Download <span class="caret"></span></button> > <ul class="dropdown-menu"> >- <li><a id="csv" href="/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Export&format=csv&report_id=[% id %]&reportname=[% name |uri %][% PROCESS params %]">Comma separated text</a></li> >+ <li><a id="csv" href="/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Export&format=csv&report_id=[% id %]&reportname=[% name |uri %][% PROCESS params %]">[% PROCESS 'delimiter_text.inc' %]</a></li> > <li><a id="tab" href="/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Export&format=tab&report_id=[% id %]&reportname=[% name |uri %][% PROCESS params %]">Tab separated text</a></li> > <li><a id="ods" href="/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Export&format=ods&report_id=[% id %]&reportname=[% name |uri %][% PROCESS params %]">Open Document Spreadsheet</a></li> > </ul> >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19910
:
70246
|
70643
|
70977
|
73494
|
73518
|
73592
|
73658