Attachment 73559 Details for Bug 19935 – Bug 19935: Replace GetPendingIssues - ILSDI

[patch] Bug 19935: Replace GetPendingIssues - ILSDI

Bug-19935-Replace-GetPendingIssues---ILSDI.patch (text/plain), 1.70 KB, created by Jonathan Druart on 2018-04-03 12:54:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-04-03 12:54:50 UTC

Size: 1.70 KB

patch

obsolete

>From efaa633119001aa12deb8683cf81f9df47391e17 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 8 Jan 2018 11:10:50 -0300
>Subject: [PATCH] Bug 19935: Replace GetPendingIssues - ILSDI
>
>Here we should only access to what we want in the template, but let do
>it as it for now.
>
>Test plan:
>Hit
>/cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=542&show_contact=0&show_loans=1
>
>With 42 a borrowernumber with checkouts
>
>Before and after these patches the XML must be the same
>
>Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no>
>---
> C4/ILSDI/Services.pm | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
>diff --git a/C4/ILSDI/Services.pm b/C4/ILSDI/Services.pm
>index 9abc87e373..158ff8e0cb 100644
>--- a/C4/ILSDI/Services.pm
>+++ b/C4/ILSDI/Services.pm
>@@ -465,12 +465,14 @@ sub GetPatronInfo {
> 
>     # Issues management
>     if ( $cgi->param('show_loans') && $cgi->param('show_loans') eq "1" ) {
>-        my $issues = GetPendingIssues($borrowernumber);
>-        foreach my $issue ( @$issues ){
>-            $issue->{'issuedate'} = $issue->{'issuedate'}->strftime('%Y-%m-%d %H:%M');
>-            $issue->{'date_due'} = $issue->{'date_due'}->strftime('%Y-%m-%d %H:%M');
>+        my $pending_checkouts = $patron->pending_checkouts;
>+        my @checkouts;
>+        while ( my $c = $pending_checkouts->next ) {
>+            # FIXME We should only retrieve what is needed in the template
>+            my $issue = $c->unblessed_all_relateds;
>+            push @checkouts, $issue
>         }
>-        $borrower->{'loans'}->{'loan'} = $issues;
>+        $borrower->{'loans'}->{'loan'} = \@checkouts;
>     }
> 
>     if ( $cgi->param('show_attributes') eq "1" ) {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 19935: 70351 | 70352 | 70353 | 70354 | 70355 | 70356 | 70357 | 70358 | 70359 | 70360 | 70361 | 71807 | 71808 | 71809 | 71810 | 71811 | 71812 | 71813 | 72752 | 72753 | 72754 | 72755 | 72756 | 72757 | 72758 | 72759 | 72760 | 72761 | 72762 | 73557 | 73558 | 73559 | 73560 | 73561 | 73562 | 73563 | 73564 | 73565 | 73566 | 73567 | 73568 | 73569 | 73570 | 73571 | 73572 | 73573 | 73574 | 73575 | 73576 | 73577 | 73578 | 73579 | 73580 | 73581 | 73582