Attachment 73563 Details for Bug 19935 – Bug 19935: Replace GetPendingIssues - opac-ics.pl

[patch] Bug 19935: Replace GetPendingIssues - opac-ics.pl

Bug-19935-Replace-GetPendingIssues---opac-icspl.patch (text/plain), 1.54 KB, created by Jonathan Druart on 2018-04-03 12:55:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-04-03 12:55:05 UTC

Size: 1.54 KB

patch

obsolete

>From 7ea0038e4e7ded8d1a8bd1a94490a19d35e336a8 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 8 Jan 2018 11:47:46 -0300
>Subject: [PATCH] Bug 19935: Replace GetPendingIssues - opac-ics.pl
>
>We only need the biblio title and the barcode, we should not need the
>whole prefetch.
>
>Test plan:
>On your OPAC summary page export your checkout list using the
>"Download as iCal/.ics file" link.
>Before and after the patchset, the generated files must be the same
>
>Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no>
>---
> opac/opac-ics.pl | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/opac/opac-ics.pl b/opac/opac-ics.pl
>index c4da67e829..1fbf351ea8 100755
>--- a/opac/opac-ics.pl
>+++ b/opac/opac-ics.pl
>@@ -50,13 +50,15 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
> # Create Calendar
> my $calendar = Data::ICal->new();
> 
>-# get issued items ....
>-my $issues = GetPendingIssues($borrowernumber);
>+my $patron = Koha::Patrons->find( $borrowernumber );
>+my $pending_checkouts = $patron->pending_checkouts;
> 
>-foreach my $issue ( @$issues ) {
>+while ( my $c = $pending_checkouts->next ) {
>+    my $issue = $c->unblessed_all_relateds;
>     my $vevent = Data::ICal::Entry::Event->new();
>     my $timestamp = DateTime->now(); # Defaults to UTC
>     # Send some values to the template to generate summary and description
>+    $issue->{overdue} = $c->is_overdue;
>     $template->param(
>         overdue => $issue->{'overdue'},
>         title   => $issue->{'title'},
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 19935: 70351 | 70352 | 70353 | 70354 | 70355 | 70356 | 70357 | 70358 | 70359 | 70360 | 70361 | 71807 | 71808 | 71809 | 71810 | 71811 | 71812 | 71813 | 72752 | 72753 | 72754 | 72755 | 72756 | 72757 | 72758 | 72759 | 72760 | 72761 | 72762 | 73557 | 73558 | 73559 | 73560 | 73561 | 73562 | 73563 | 73564 | 73565 | 73566 | 73567 | 73568 | 73569 | 73570 | 73571 | 73572 | 73573 | 73574 | 73575 | 73576 | 73577 | 73578 | 73579 | 73580 | 73581 | 73582