Bugzilla – Attachment 7360 Details for
Bug 6875
de-nesting C4 packages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED_QA][PATCH 06]Bug 6875 de-nesting C4::Koha.pm
Bug-6875-de-nesting-C4Kohapm.patch (text/plain), 1.61 KB, created by
Jared Camins-Esakov
on 2012-01-28 14:06:58 UTC
(
hide
)
Description:
[PASSED_QA][PATCH 06]Bug 6875 de-nesting C4::Koha.pm
Filename:
MIME Type:
Creator:
Jared Camins-Esakov
Created:
2012-01-28 14:06:58 UTC
Size:
1.61 KB
patch
obsolete
>From 7282b038bc7936079101d2f4e7a78065792e1dfb Mon Sep 17 00:00:00 2001 >From: Paul Poulain <paul.poulain@biblibre.com> >Date: Fri, 16 Sep 2011 18:28:00 +0200 >Subject: [PATCH] Bug 6875 de-nesting C4::Koha.pm >Content-Type: text/plain; charset="UTF-8" > >* removed use C4::Output, that was not used >* moved use URI::split to getitemtypeimagelocation and switched to "require". > Checked it still works through admin/itemtype.pl >* moved use Business::ISBN to _isbn_cleanup.pl and switched to "require". > Checked it still works with the following small script : > >use C4::Koha; >print GetNormalizedISBN("1-56592-257-3"); > >(GetNormalizedISBN uses _isbn_cleanup) > >Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> >--- > C4/Koha.pm | 7 +++---- > 1 files changed, 3 insertions(+), 4 deletions(-) > >diff --git a/C4/Koha.pm b/C4/Koha.pm >index 789f674..976b46a 100644 >--- a/C4/Koha.pm >+++ b/C4/Koha.pm >@@ -23,10 +23,7 @@ package C4::Koha; > use strict; > #use warnings; FIXME - Bug 2505 > use C4::Context; >-use C4::Output; >-use URI::Split qw(uri_split); > use Memoize; >-use Business::ISBN; > > use vars qw($VERSION @ISA @EXPORT $DEBUG); > >@@ -472,8 +469,9 @@ sub getitemtypeimagelocation($$) { > my ( $src, $image ) = @_; > > return '' if ( !$image ); >+ require URI::Split; > >- my $scheme = ( uri_split( $image ) )[0]; >+ my $scheme = ( URI::Split::uri_split( $image ) )[0]; > > return $image if ( $scheme ); > >@@ -1315,6 +1313,7 @@ sub _normalize_match_point { > } > > sub _isbn_cleanup { >+ require Business::ISBN; > my $isbn = Business::ISBN->new( $_[0] ); > if ( $isbn ) { > $isbn = $isbn->as_isbn10 if $isbn->type eq 'ISBN13'; >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6875
:
5442
|
5443
|
5496
|
5497
|
5498
|
5499
|
5500
|
5501
|
5502
|
5503
|
5504
|
5505
|
5506
|
5507
|
5508
|
5509
|
5510
|
5511
|
5512
|
7359
|
7360
|
7361
|
7362
|
7363
|
7364
|
7365
|
7652
|
7654
|
7655
|
7656
|
7657
|
7658
|
7770
|
7771
|
7808
|
7844
|
8095
|
8133
|
8134
|
8135