Attachment 73785 Details for Bug 12310 – Bug 12310: Follow up to keep example text

[patch] Bug 12310: Follow up to keep example text

Bug-12310-Follow-up-to-keep-example-text.patch (text/plain), 3.13 KB, created by Mark Tompsett on 2018-04-06 14:20:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2018-04-06 14:20:33 UTC

Size: 3.13 KB

patch

obsolete

>From f4372d58bf33266597018ae8af4f326971f54541 Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Fri, 6 Apr 2018 14:15:59 +0000
>Subject: [PATCH] Bug 12310: Follow up to keep example text
>
>This put the example text back in with the correct decimal
>separator.
>
>TEST PLAN
>---------
>1) Test first patch
>2) Go to a patron's fines tab.
>3) Confirm that Create manual invoice and Create manual credit
>   tabs both have blank amounts.
>4) apply this patch
>5) restart_all
>6) reload the page and check both create tabs.
>   -- Example appears.
>7) set your I18N/L10N DecimalSeparators to something strange like #.
>8) go back and check both tabs.
>   -- Example appears with the decimal separator that was set.
>9) run koha qa test tools
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt  | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt
>index 859e08c..33ab577 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt
>@@ -41,7 +41,7 @@
> 	<li><label for="barcode">Barcode: </label><input type="text" name="barcode" id="barcode" /></li>
> 	<li><label for="desc">Description: </label><input type="text" name="desc" size="50" id="desc" /></li>
>     <li><label for="note">Note: </label><input type="text" name="note" size="50" id="note" /></li>
>-    <li><label for="amount">Amount: </label><input name="amount" id="amount" class="decimal-unformating" required="required" value="" step="any" min="0" /></li>
>+    <li><label for="amount">Amount: </label><input name="amount" id="amount" class="decimal-unformating" required="required" value="" step="any" min="0" placeholder="Example 5[% Koha.Preference('DecimalSeparators') || '.' %]00" /></li>
> 
> </ol></fieldset>
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt
>index 891d4b8..8a8413d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt
>@@ -53,7 +53,7 @@
> 	<li><label for="barcode">Barcode: </label><input type="text" name="barcode" id="barcode" /></li>
> 	<li><label for="desc">Description: </label><input type="text" name="desc" id="desc" size="50" /></li>
>     <li><label for="note">Note: </label><input type="text" name="note" size="50" id="note" /></li>
>-    <li><label for="amount">Amount: </label><input type="text" name="amount" id="amount" class="decimal-unformating" required="required"/></li>
>+    <li><label for="amount">Amount: </label><input type="text" name="amount" id="amount" class="decimal-unformating" required="required" placeholder="Example 5[% Koha.Preference('DecimalSeparators') || '.' %]00"/></li>
> 	</ol></fieldset>
> <fieldset class="action"><input type="submit" name="add" value="Save" /> <a class="cancel" href="/cgi-bin/koha/members/boraccount.pl?borrowernumber=[% patron.borrowernumber %]">Cancel</a></fieldset>
> </form>
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 12310: 28455 | 60530 | 60563 | 61357 | 61603 | 61604 | 62655 | 64671 | 64672 | 64673 | 64674 | 64675 | 64678 | 64679 | 64696 | 72104 | 72213 | 72983 | 73055 | 73215 | 73546 | 73657 | 73784 | 73785 | 73873 | 73874 | 73880 | 74524 | 74525 | 74526 | 74527 | 74528 | 74529 | 75123 | 75127 | 75128 | 75129 | 75130 | 75947 | 75948 | 75949 | 75950 | 75951 | 75952 | 75954 | 75955 | 75956 | 75957 | 75958 | 75959 | 76896 | 76933 | 77971 | 77972 | 77973 | 77995 | 78017 | 78631 | 78632 | 78633 | 78634 | 78635 | 78636 | 78637 | 78638