Bugzilla – Attachment 73816 Details for
Bug 8643
Add ability to mark some MARC tags and subfields as important and alert on saving the record if they are found to be empty
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8643: (QA follow-up) Fix alert, clean up patch, improve db update
Bug-8643-QA-follow-up-Fix-alert-clean-up-patch-imp.patch (text/plain), 3.03 KB, created by
Katrin Fischer
on 2018-04-07 08:46:09 UTC
(
hide
)
Description:
Bug 8643: (QA follow-up) Fix alert, clean up patch, improve db update
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2018-04-07 08:46:09 UTC
Size:
3.03 KB
patch
obsolete
>From 079a97e711394c0c8ec24d2f57305e5b86c52d61 Mon Sep 17 00:00:00 2001 >From: Charles Farmer <charles.farmer@inLibro.com> >Date: Fri, 23 Feb 2018 15:02:50 -0500 >Subject: [PATCH] Bug 8643: (QA follow-up) Fix alert, clean up patch, improve > db update > >* Field 'important' now added after 'mandatory' in table marc_tag_structure >* Removed modification on table serialitems in kohastructure.sql >* Removed bogus line in marctagstructure.tt >* Fixed the missing tag number in the alert message > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > installer/data/mysql/atomicupdate/bug-8643-add_important_constraint.sql | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt | 1 - > koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt | 2 +- > 3 files changed, 2 insertions(+), 3 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug-8643-add_important_constraint.sql b/installer/data/mysql/atomicupdate/bug-8643-add_important_constraint.sql >index 0ffb746db5..4eda4ce5aa 100644 >--- a/installer/data/mysql/atomicupdate/bug-8643-add_important_constraint.sql >+++ b/installer/data/mysql/atomicupdate/bug-8643-add_important_constraint.sql >@@ -1,5 +1,5 @@ > ALTER TABLE marc_subfield_structure ADD COLUMN important TINYINT(4) NOT NULL DEFAULT 0 AFTER mandatory; >-ALTER TABLE marc_tag_structure ADD COLUMN important TINYINT(4) NOT NULL DEFAULT 0 AFTER frameworkcode; >+ALTER TABLE marc_tag_structure ADD COLUMN important TINYINT(4) NOT NULL DEFAULT 0 AFTER mandatory; > > -- $DBversion = "3.23.00.XXX"; > -- if ( CheckVersion($DBversion) ) { >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt >index ad8f95fd24..353bbbbd96 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt >@@ -92,7 +92,6 @@ > <input type="checkbox" name="important" id="important" value="1" /> > [% END %] > </li> >- <li><label for="authorised_value">Authorized value: </label>[% authorised_value %] (if you select a value here, the indicators will be limited to the authorized value list)</li> > </ol></fieldset> > <fieldset class="action"> > <input type="submit" value="Save changes" /> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >index 3209f63927..ef9412db7e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >@@ -377,7 +377,7 @@ function AreImportantsNotOk(){ > [% END %] > [% FOREACH subfield_loo IN innerloo.subfield_loop %] > [% IF ( subfield_loo.important ) %]importants.push("[% subfield_loo.id %]"); >- tab.push("[% subfield_loo.number %]"); >+ tab.push("[% BIG_LOO.number %]"); > label.push("[% subfield_loo.marc_lib %]"); > [% END %] > [% END %] >-- >2.14.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8643
:
11621
|
11622
|
30640
|
31032
|
40232
|
40237
|
41259
|
41261
|
41264
|
41265
|
45834
|
45835
|
45836
|
45837
|
60554
|
60555
|
65148
|
65149
|
65682
|
72154
|
72155
|
72156
|
72157
|
73591
|
73808
|
73809
|
73810
|
73811
|
73812
|
73813
|
73814
|
73815
|
73816
|
73817
|
73818
|
74267
|
74268
|
74269
|
74270
|
74271
|
74272
|
74273
|
81032
|
85982
|
91537
|
92081
|
92384
|
96625
|
96627
|
97325
|
97326
|
98607
|
98608
|
98702
|
98703
|
98712