Attachment 73858 Details for Bug 19457 – Bug 19457: If CheckPrevCheckout is set to Do, then checkouts are blocked at the SIPServer

[patch] Bug 19457: If CheckPrevCheckout is set to Do, then checkouts are blocked at the SIPServer

Bug-19457-If-CheckPrevCheckout-is-set-to-Do-then-c.patch (text/plain), 1.57 KB, created by Kyle M Hall (khall) on 2018-04-09 11:18:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2018-04-09 11:18:54 UTC

Size: 1.57 KB

patch

obsolete

>From 3196349f9856874de1cad22b7070b5ee821a244d Mon Sep 17 00:00:00 2001
>From: Liz Rea <liz@catalyst.net.nz>
>Date: Fri, 2 Feb 2018 11:48:30 +1300
>Subject: [PATCH] Bug 19457: If CheckPrevCheckout is set to Do, then checkouts
> are blocked at the SIPServer
>
>To test:
>
>Set CheckPrevCheckout to Do, or Do, with confirmation
>Verify the SIP server is blocking checkouts with this setting set
>Apply this patch
>Note that the checkout is now allowed, with a screen message telling the borrower they've issued the item before.y
>
>Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> C4/SIP/ILS/Transaction/Checkout.pm | 7 +++++++
> 1 file changed, 7 insertions(+)
>
>diff --git a/C4/SIP/ILS/Transaction/Checkout.pm b/C4/SIP/ILS/Transaction/Checkout.pm
>index 23cdec92c4..054b17aeb7 100644
>--- a/C4/SIP/ILS/Transaction/Checkout.pm
>+++ b/C4/SIP/ILS/Transaction/Checkout.pm
>@@ -97,6 +97,13 @@ sub do_checkout {
>                     $noerror = 0;
>                     last;
>                 }
>+             } elsif (
>+                  $confirmation eq 'PREVISSUE'
>+                  && (   C4::Context->preference('CheckPrevCheckout') eq "softyes"
>+                      || C4::Context->preference('CheckPrevCheckout') eq "hardyes" )
>+                ) {
>+                $self->screen_msg("This item was previously checked out by you");
>+                last;
>             } else {
>                 # We've been returned a case other than those above
>                 $self->screen_msg("Item cannot be issued: $confirmation");
>-- 
>2.15.1 (Apple Git-101)

Actions: View | Diff | Splinter Review

Attachments on bug 19457: 72187 | 72216 | 72771 | 73858 | 78567 | 78597 | 89674 | 90216