Bugzilla – Attachment 73867 Details for
Bug 19581
Elasticsearch - Catmandu split option adds extra null fields to indexes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19581: (follow-up) Fix handling of new and old arrays for auth compat
Bug-19581-follow-up-Fix-handling-of-new-and-old-ar.patch (text/plain), 1.32 KB, created by
Julian Maurice
on 2018-04-09 12:47:20 UTC
(
hide
)
Description:
Bug 19581: (follow-up) Fix handling of new and old arrays for auth compat
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2018-04-09 12:47:20 UTC
Size:
1.32 KB
patch
obsolete
>From 5d911571c14cd5db63ecaa25b57d0b9c2ecafbb6 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 16 Mar 2018 09:03:46 +0000 >Subject: [PATCH] Bug 19581: (follow-up) Fix handling of new and old arrays for > auth compat > >Stolen from bug 20244 > >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > Koha/SearchEngine/Elasticsearch/Search.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/Koha/SearchEngine/Elasticsearch/Search.pm b/Koha/SearchEngine/Elasticsearch/Search.pm >index b8f03cbc70..063dca306b 100644 >--- a/Koha/SearchEngine/Elasticsearch/Search.pm >+++ b/Koha/SearchEngine/Elasticsearch/Search.pm >@@ -200,9 +200,9 @@ sub search_auth_compat { > > # I wonder if these should be real values defined in the mapping > # rather than hard-coded conversions. >- # Our results often come through as nested arrays, to fix this >- # requires changes in catmandu. >- my $authid = $record->{ 'Local-number' }[0][0]; >+ # Handle legacy nested arrays indexed with splitting enabled. >+ my $authid = $record->{ 'Local-number' }[0]; >+ $authid = @$authid[0] if (ref $authid eq 'ARRAY'); > $result{authid} = $authid; > > # TODO put all this info into the record at index time so we >-- >2.14.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19581
:
68947
|
68948
|
68949
|
69092
|
69093
|
72745
|
72767
|
72997
|
73864
|
73865
|
73866
| 73867 |
73896