Bugzilla – Attachment 73944 Details for
Bug 20388
Ability to add search fields from UI
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20388 - Keep data consistency when adding/removing mapping
Bug-20388---Keep-data-consistency-when-addingremov.patch (text/plain), 2.33 KB, created by
Alex Arnaud
on 2018-04-10 14:56:24 UTC
(
hide
)
Description:
Bug 20388 - Keep data consistency when adding/removing mapping
Filename:
MIME Type:
Creator:
Alex Arnaud
Created:
2018-04-10 14:56:24 UTC
Size:
2.33 KB
patch
obsolete
>From 754fa2b9f08cb5e6920b289b5c25f0f3304443ee Mon Sep 17 00:00:00 2001 >From: Alex Arnaud <alex.arnaud@gmail.com> >Date: Wed, 4 Apr 2018 13:05:39 +0000 >Subject: [PATCH] Bug 20388 - Keep data consistency when adding/removing > mapping > >Test plan: > - create a new search field, save, > - create a mapping using it (don't save), > - check that you can't delete the search field. > > - delete all the mapping related to a search field (biblios and > authorities), don't save, > - check that you can delete this search field. > >Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> >--- > .../en/modules/admin/searchengine/elasticsearch/mappings.tt | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt >index 5abc149..e5ee147 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt >@@ -27,6 +27,14 @@ > $("#tabs").tabs(); > $('.delete').click(function() { > $(this).parents('tr').remove(); >+ >+ var line = $(this).closest("tr"); >+ var search_field_name = $(line).find('input[name="mapping_search_field_name"]').val(); >+ var mappings = $('input[name="mapping_search_field_name"][type="hidden"][value="' + search_field_name + '"]'); >+ if (mappings.length == 0) { >+ var search_field_line = $('input[name="search_field_name"][value="' + search_field_name + '"]').closest("tr"); >+ $(search_field_line).find('a.btn-default').removeClass('disabled'); >+ } > }); > > $("table.mappings").tableDnD( { >@@ -43,6 +51,11 @@ > $('.delete').click(function() { > $(this).parents('tr').remove(); > }); >+ >+ var search_field_name = $(line).find('select[data-id="mapping_search_field_name"] option:selected').text(); >+ var search_field_line = $('input[name="search_field_name"][value="' + search_field_name + '"]').closest("tr"); >+ $(search_field_line).find('a.btn-default').addClass('disabled'); >+ > clean_line(line); > > $(table).tableDnD( { >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20388
:
73158
|
73165
|
73167
|
73476
|
73626
|
73627
|
73629
|
73681
|
73682
|
73918
|
73919
|
73940
|
73943
|
73944
|
73945
|
73946
|
74261
|
74718
|
74719
|
78658
|
78659
|
80709
|
86912
|
87196
|
87197
|
87198
|
87199
|
87201
|
87202
|
87203
|
87204
|
88075
|
88079
|
88080
|
88081
|
88082
|
88083
|
89117
|
89118
|
89121
|
89733
|
89894
|
90517
|
90518
|
90519
|
90520
|
90521
|
90522
|
90523
|
90524
|
98011
|
98012
|
98013
|
98014
|
98015
|
98016
|
98017
|
98018
|
99960
|
99961
|
99962
|
99963
|
99964
|
99965
|
99966
|
99967
|
119296
|
119317
|
119318
|
120104
|
163449
|
163450
|
163451
|
163452
|
163460
|
163461
|
163462
|
163463
|
164529
|
164530
|
164531
|
164532
|
164533
|
164534
|
164535
|
164789
|
164790
|
164791
|
164792
|
164793