Attachment 73958 Details for Bug 20557 – Bug 20557: Prevent Koha/Acquisition/Order.t to fail randomly

[patch] Bug 20557: Prevent Koha/Acquisition/Order.t to fail randomly

Bug-20557-Prevent-KohaAcquisitionOrdert-to-fail-ra.patch (text/plain), 1.71 KB, created by Jonathan Druart on 2018-04-10 16:09:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-04-10 16:09:43 UTC

Size: 1.71 KB

patch

obsolete

>From 1afffa3a8316e9b8e82ba3a915c86659299fec3f Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 10 Apr 2018 13:08:43 -0300
>Subject: [PATCH] Bug 20557: Prevent Koha/Acquisition/Order.t to fail randomly
>
>https://jenkins.koha-community.org/job/Koha_Master_D8/427/consoleFull
>
>t/db_dependent/Koha/Acquisition/Order.t .. 1/2         # No tests run!
>
>    #   Failed test 'No tests run for subtest "entrydate"'
>    #   at t/db_dependent/Koha/Acquisition/Order.t line 97.
>    # Looks like you failed 1 test of 1.
>
> #   Failed test 'store'
> #   at t/db_dependent/Koha/Acquisition/Order.t line 99.
> Cannot insert order: Mandatory parameter quantity is missing at t/db_dependent/Koha/Acquisition/Order.t line 77.
> # Looks like your test exited with 255 just after 2.
>
>It happens when basket.is_standing is 0
>---
> t/db_dependent/Koha/Acquisition/Order.t | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/t/db_dependent/Koha/Acquisition/Order.t b/t/db_dependent/Koha/Acquisition/Order.t
>index ed9ebc0c48..f8382fa331 100644
>--- a/t/db_dependent/Koha/Acquisition/Order.t
>+++ b/t/db_dependent/Koha/Acquisition/Order.t
>@@ -77,6 +77,7 @@ subtest 'store' => sub {
>                 basketno     => $o->basketno,
>                 biblionumber => $o->biblionumber,
>                 budget_id    => $o->budget_id,
>+                quantity     => 1,
>             }
>         )->store;
>         $order->discard_changes;
>@@ -88,6 +89,7 @@ subtest 'store' => sub {
>                 basketno     => $o->basketno,
>                 biblionumber => $o->biblionumber,
>                 budget_id    => $o->budget_id,
>+                quantity     => 1,
>             }
>         )->store;
>         $order->discard_changes;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20557: 73958