Attachment 73972 Details for Bug 19936 – Bug 19936: Remove warnings from tests

[patch] Bug 19936: Remove warnings from tests

Bug-19936-Remove-warnings-from-tests.patch (text/plain), 998 bytes, created by Josef Moravec on 2018-04-10 21:38:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2018-04-10 21:38:19 UTC

Size: 998 bytes

patch

obsolete

>From 371e0933a19f1329560ed1f6364fa320cb626600 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 9 Jan 2018 10:33:25 -0300
>Subject: [PATCH] Bug 19936: Remove warnings from tests
>
>C4::Members did not "use warnings;"
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>---
> Koha/Patron.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Patron.pm b/Koha/Patron.pm
>index 8a37d2a..7458bc5 100644
>--- a/Koha/Patron.pm
>+++ b/Koha/Patron.pm
>@@ -917,8 +917,8 @@ sub generate_userid {
>     my $userid;
>     my $offset = 0;
>     my $patron = Koha::Patron->new;
>-    my $firstname = $self->firstname;
>-    my $surname = $self->surname;
>+    my $firstname = $self->firstname // q{};
>+    my $surname = $self->surname // q{};
>     #The script will "do" the following code and increment the $offset until the generated userid is unique
>     do {
>       $firstname =~ s/[[:digit:][:space:][:blank:][:punct:][:cntrl:]]//g;
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 19936: 70365 | 70366 | 70367 | 70368 | 70369 | 70370 | 70371 | 70372 | 70373 | 70374 | 71787 | 71788 | 71789 | 71790 | 71791 | 71792 | 71793 | 71794 | 71795 | 71796 | 72129 | 72130 | 72131 | 72132 | 72133 | 72134 | 72135 | 72136 | 72137 | 72138 | 72139 | 72140 | 72141 | 72142 | 72143 | 72144 | 72145 | 72146 | 72147 | 72148 | 72149 | 72150 | 72151 | 72152 | 73630 | 73631 | 73632 | 73633 | 73634 | 73635 | 73636 | 73637 | 73638 | 73639 | 73640 | 73641 | 73963 | 73964 | 73965 | 73966 | 73967 | 73968 | 73969 | 73970 | 73971 | 73972 | 73973 | 73974 | 74071 | 74072 | 74073 | 74074 | 74075 | 74076 | 74077 | 74078 | 74079 | 74080 | 74081 | 74082