Bugzilla – Attachment 74067 Details for
Bug 20515
"ILL Request" menu options displayed when user has no ILL permissions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20515: Fix permission check on "ILL request" menu options
Bug-20515-Fix-permission-check-on-ILL-request-menu.patch (text/plain), 2.89 KB, created by
Katrin Fischer
on 2018-04-12 10:06:47 UTC
(
hide
)
Description:
Bug 20515: Fix permission check on "ILL request" menu options
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2018-04-12 10:06:47 UTC
Size:
2.89 KB
patch
obsolete
>From 3ac190145733ea7936204830a82a32605f436a39 Mon Sep 17 00:00:00 2001 >From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> >Date: Wed, 4 Apr 2018 12:09:52 +0100 >Subject: [PATCH] Bug 20515: Fix permission check on "ILL request" menu options > >This patch adds the following additional conditions to the display of >both the ILL Requests drop down "More" menu option and the "ILL Requests" >option on the intranet front page: > >Before: > >[% IF Koha.Preference('ILLModule') %] > >After: > >[% IF Koha.Preference('ILLModule') && (CAN_user_ill || CAN_user_superlibrarian) %] > >This prevents the options being displayed to users who have no >permissions to work with ILL. > >Test plan: > >View both the intranet front page and "More" dropdown while logged in as >a user without ILL permissions, ensure the options do not display. Then >do the same with a user with ILL permissions, ensure the options do >display. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/header.inc | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc >index 46d8db8774..73ed6f9e79 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc >@@ -28,7 +28,7 @@ > <li><a href="/cgi-bin/koha/acqui/acqui-home.pl">Acquisitions</a></li> > [% END %] > <li><a href="/cgi-bin/koha/authorities/authorities-home.pl">Authorities</a></li> >- [% IF ( Koha.Preference('ILLModule') ) %] >+ [% IF ( Koha.Preference('ILLModule') && (CAN_user_ill || CAN_user_superlibrarian) ) %] > <li><a href="/cgi-bin/koha/ill/ill-requests.pl">ILL Requests</a></li> > [% END %] > [% IF ( CAN_user_serials ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt >index dc619926ba..64d4223039 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt >@@ -80,7 +80,7 @@ > <li> > <a class="icon_general icon_authorities" href="/cgi-bin/koha/authorities/authorities-home.pl">Authorities</a> > </li> >- [% IF Koha.Preference('ILLModule') %] >+ [% IF Koha.Preference('ILLModule') && (CAN_user_ill || CAN_user_superlibrarian) %] > <li> > <a class="icon_general icon_ill" href="/cgi-bin/koha/ill/ill-requests.pl">ILL requests</a> > </li> >-- >2.14.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20515
:
73615
|
73643
|
73875
|
74065
|
74066
| 74067 |
74068
|
74154
|
74194
|
74195