Bugzilla – Attachment 74131 Details for
Bug 20271
Merge deleted biblio, biblioitems, biblio_metadata, and items tables
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20271: remove comments regarding deleteditems and -biblio*
Bug-20271-remove-comments-regarding-deleteditems-a.patch (text/plain), 2.63 KB, created by
Benjamin Rokseth
on 2018-04-13 07:18:25 UTC
(
hide
)
Description:
Bug 20271: remove comments regarding deleteditems and -biblio*
Filename:
MIME Type:
Creator:
Benjamin Rokseth
Created:
2018-04-13 07:18:25 UTC
Size:
2.63 KB
patch
obsolete
>From 0ead75c9776f97c361c49d4624796d635fadf79a Mon Sep 17 00:00:00 2001 >From: Benjamin Rokseth <benjamin.rokseth@deichman.no> >Date: Tue, 3 Apr 2018 00:17:46 +0200 >Subject: [PATCH] Bug 20271: remove comments regarding deleteditems and > -biblio* > >--- > C4/Biblio.pm | 17 ++++++----------- > 1 file changed, 6 insertions(+), 11 deletions(-) > >diff --git a/C4/Biblio.pm b/C4/Biblio.pm >index cf0abe0..3c4f9ae 100644 >--- a/C4/Biblio.pm >+++ b/C4/Biblio.pm >@@ -414,7 +414,7 @@ sub DelBiblio { > # and we would have no way to remove it (except manually in zebra, but I bet it would be very hard to handle the problem) > ModZebra( $biblionumber, "recordDelete", "biblioserver" ); > >- # delete biblioitems and items from Koha tables and save in deletedbiblioitems,deleteditems >+ # mark biblioitems and items as deleted > $sth = $dbh->prepare("SELECT biblioitemnumber FROM biblioitems WHERE biblionumber=? AND deleted_at IS NULL"); > $sth->execute($biblionumber); > while ( my $biblioitemnumber = $sth->fetchrow ) { >@@ -424,11 +424,6 @@ sub DelBiblio { > return $error if $error; > } > >- >- # delete biblio from Koha tables and save in deletedbiblio >- # must do this *after* _koha_delete_biblioitems, otherwise >- # delete cascade will prevent deletedbiblioitems rows >- # from being generated by _koha_delete_biblioitems > $error = _koha_delete_biblio( $dbh, $biblionumber ); > > logaction( "CATALOGUING", "DELETE", $biblionumber, "biblio" ) if C4::Context->preference("CataloguingLog"); >@@ -3071,11 +3066,11 @@ sub _koha_add_biblioitem { > > $error = _koha_delete_biblio($dbh,$biblionumber); > >-Internal sub for deleting from biblio table -- also saves to deletedbiblio >+Internal sub for deleting from biblio table > > C<$dbh> - the database handle > >-C<$biblionumber> - the biblionumber of the biblio to be deleted >+C<$biblionumber> - the biblionumber of the biblio (and metadata) to be marked as deleted > > =cut > >@@ -3092,10 +3087,10 @@ sub _koha_delete_biblio { > > $error = _koha_delete_biblioitems($dbh,$biblioitemnumber); > >-Internal sub for deleting from biblioitems table -- also saves to deletedbiblioitems >+Internal sub for deleting from biblioitems table > > C<$dbh> - the database handle >-C<$biblionumber> - the biblioitemnumber of the biblioitem to be deleted >+C<$biblionumber> - the biblioitemnumber of the biblioitem to be marked as deleted > > =cut > >@@ -3111,7 +3106,7 @@ sub _koha_delete_biblioitems { > > $error = _koha_delete_biblio_metadata($biblionumber); > >-C<$biblionumber> - the biblionumber of the biblio metadata to be deleted >+C<$biblionumber> - the biblionumber of the biblio metadata to be marked as deleted > > =cut > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20271
:
72300
|
72799
|
72800
|
73091
|
73092
|
73093
|
73535
|
73536
|
73537
|
73538
|
73539
|
73540
|
73597
|
73759
|
73760
|
73761
|
73762
|
73763
|
73764
|
73765
|
74127
|
74128
|
74129
|
74130
|
74131
|
74132
|
74133
|
74134
|
74135
|
74136
|
74137
|
74138
|
74139
|
74140
|
74141
|
74142
|
74182
|
74183
|
74184
|
74185
|
74186
|
74187
|
74188
|
74189
|
74190
|
74223
|
74407
|
74408
|
74409
|
74410
|
74411
|
74412
|
74413
|
74414
|
74415
|
74416
|
75265
|
75347
|
75894
|
75897
|
75898
|
75899
|
75910
|
75977
|
75978
|
75979
|
75980
|
75981
|
75982
|
75983
|
75984
|
75985
|
75986
|
75987
|
75988
|
75989
|
75990
|
75991
|
75992
|
75993
|
76047
|
76048
|
76255
|
76256
|
76257
|
76258
|
76259
|
76260
|
76261
|
76262
|
76263
|
76264
|
76265
|
76266
|
76267
|
76268
|
76269
|
76270
|
76271
|
76272
|
76273
|
76274
|
76275
|
76276
|
76277
|
76493
|
76494
|
76495
|
76496
|
76497
|
76498
|
76499
|
76500
|
76501
|
76502
|
76503
|
76504
|
76505
|
76506
|
76507
|
76508
|
76509
|
76510
|
76511
|
76512
|
76513
|
76514