Attachment 74151 Details for Bug 20489 – Bug 20489: Remove warnings from the interface

[patch] Bug 20489: Remove warnings from the interface

Bug-20489-Remove-warnings-from-the-interface.patch (text/plain), 4.07 KB, created by Marcel de Rooy on 2018-04-13 10:07:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2018-04-13 10:07:24 UTC

Size: 4.07 KB

patch

obsolete

>From fa9ecd5b82662c8f3bab4729bfbf63e1348c1ed7 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 28 Mar 2018 14:49:18 -0300
>Subject: [PATCH] Bug 20489: Remove warnings from the interface
>Content-Type: text/plain; charset=utf-8
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt |  7 -------
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt    | 11 -----------
> mainpage.pl                                              |  7 -------
> opac/opac-user.pl                                        |  4 ----
> 4 files changed, 29 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
>index dc61992..f6fcd39 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
>@@ -34,13 +34,6 @@
>                 [% END %]
>             </div> 
>             <div class="col-sm-9">
>-                [% IF adminWarning %]
>-                    <div id="adminwarning" class="dialog alert">
>-                        <p><strong>Warning:</strong> You are logged in as the database administrative user. This is not recommended because some parts of Koha will not function as expected when using this account.</p>
>-                        <p>Please log in instead with a regular staff account. To create a staff account, create a library, a patron category 'Staff' and add a new patron. Then give this patron permissions from 'More' in the toolbar.</p>
>-                        <p><a class="btn btn-default btn-sm" href="/cgi-bin/koha/members/members-home.pl"><i class="fa fa-plus"> </i> Create patron</a></p>
>-                    </div>
>-                [% END %]
>                 <div class="row">
>                     <div class="col-xs-6">
>                         <ul class="biglinks-list">
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>index 9eabf10..3556298 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>@@ -38,17 +38,6 @@
>             <div class="span10">
>                 <div id="userdetails" class="maincontent">
> 
>-                    [% IF adminWarning %]
>-                        <div id="adminwarning" class="dialog alert">
>-                            <p>
>-<strong><i class="fa fa-exclamation-triangle"> </i> Warning:</strong>
>-Using this account is not recommended because some parts of Koha will not function as expected. Instead, please log in with a different account.
>-<a class="btn btn-small" href="/cgi-bin/koha/opac-main.pl?logout.x=1">
>-<i class="fa fa-sign-out"> </i> Log out</a>
>-                            </p>
>-                        </div>
>-                    [% END %]
>-
>                     [% INCLUDE 'opac-note.inc' %]
> 
>                     <h2>Hello, [% INCLUDE 'patron-title.inc' category_type = BORROWER_INFO.category_type firstname = BORROWER_INFO.firstname surname = BORROWER_INFO.surname othernames = BORROWER_INFO.othernames cardnumber = BORROWER_INFO.cardnumber %]
>diff --git a/mainpage.pl b/mainpage.pl
>index 47f56ad..da6aaee 100755
>--- a/mainpage.pl
>+++ b/mainpage.pl
>@@ -84,11 +84,4 @@ $template->param(
>     pending_article_requests       => $pending_article_requests,
> );
> 
>-#
>-# warn user if they are using mysql/admin login
>-#
>-unless ($loggedinuser) {
>-    $template->param(adminWarning => 1);
>-}
>-
> output_html_with_http_headers $query, $cookie, $template->output;
>diff --git a/opac/opac-user.pl b/opac/opac-user.pl
>index ab3d8a7..3400f39 100755
>--- a/opac/opac-user.pl
>+++ b/opac/opac-user.pl
>@@ -88,10 +88,6 @@ my $canrenew = 1;
> 
> $template->param( shibbolethAuthentication => C4::Context->config('useshibboleth') );
> 
>-if (!$borrowernumber) {
>-    $template->param( adminWarning => 1 );
>-}
>-
> # get borrower information ....
> my $patron = Koha::Patrons->find( $borrowernumber );
> my $borr = $patron->unblessed;
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 20489: 73400 | 73402 | 73425 | 73528 | 73529 | 73543 | 73544 | 74150 | 74151