Bugzilla – Attachment 74171 Details for
Bug 20538
Remove the need of writing [% KOHA_VERSION %] everywhere
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20538: ->tag is private - tell it explicitly
Bug-20538--tag-is-private---tell-it-explicitly.patch (text/plain), 1.27 KB, created by
Jonathan Druart
on 2018-04-13 15:08:23 UTC
(
hide
)
Description:
Bug 20538: ->tag is private - tell it explicitly
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-04-13 15:08:23 UTC
Size:
1.27 KB
patch
obsolete
>From cae73d4782c72ba9864df857a3f69f4835f153b7 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 13 Apr 2018 12:08:07 -0300 >Subject: [PATCH] Bug 20538: ->tag is private - tell it explicitly > >--- > Koha/Template/Plugin/Asset.pm | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > >diff --git a/Koha/Template/Plugin/Asset.pm b/Koha/Template/Plugin/Asset.pm >index 5b78345174..4cbc1bd0e8 100644 >--- a/Koha/Template/Plugin/Asset.pm >+++ b/Koha/Template/Plugin/Asset.pm >@@ -86,7 +86,7 @@ sub js { > > $attributes->{src} = $url; > >- return $self->tag('script', $attributes) . '</script>'; >+ return $self->_tag('script', $attributes) . '</script>'; > } > > =head2 css >@@ -111,7 +111,7 @@ sub css { > $attributes->{type} = 'text/css'; > $attributes->{href} = $url; > >- return $self->tag('link', $attributes); >+ return $self->_tag('link', $attributes); > } > > =head2 url >@@ -149,16 +149,14 @@ sub url { > } > } > >-=head2 tag >+=head2 _tag > > Returns an HTML tag with given name and attributes. > This shouldn't be used directly. > >- [% Asset.tag("script", { src = "/koha-tmpl/intranet-tmpl/prog/css/datatables.css" }) %] >- > =cut > >-sub tag { >+sub _tag { > my ($self, $name, $attributes) = @_; > > my @attributes_strs; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20538
:
73791
|
73836
|
74048
|
74049
|
74053
|
74054
|
74056
|
74057
|
74058
|
74059
|
74060
|
74061
|
74062
|
74063
| 74171 |
74835