Bugzilla – Attachment 74247 Details for
Bug 18725
process_message_queue.pl sends duplicate emails if message_queue is not writable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18725: Test return values of make_column_dirty
Bug-18725-Test-return-values-of-makecolumndirty.patch (text/plain), 1.34 KB, created by
Jonathan Druart
on 2018-04-16 15:56:18 UTC
(
hide
)
Description:
Bug 18725: Test return values of make_column_dirty
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-04-16 15:56:18 UTC
Size:
1.34 KB
patch
obsolete
>From ae1c306ac25663e04e8670911f3930889808029a Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 16 Apr 2018 12:56:01 -0300 >Subject: [PATCH] Bug 18725: Test return values of make_column_dirty > >--- > t/db_dependent/Koha/Object.t | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Koha/Object.t b/t/db_dependent/Koha/Object.t >index a0c72e4058..7998b05e7f 100755 >--- a/t/db_dependent/Koha/Object.t >+++ b/t/db_dependent/Koha/Object.t >@@ -44,7 +44,7 @@ my $schema = Koha::Database->new->schema; > my $builder = t::lib::TestBuilder->new(); > > subtest 'is_changed / make_column_dirty' => sub { >- plan tests => 9; >+ plan tests => 11; > > $schema->storage->txn_begin; > >@@ -71,7 +71,8 @@ subtest 'is_changed / make_column_dirty' => sub { > is( $object->is_changed(), 0, "Object no longer marked as changed after being stored" ); > > # Test make_column_dirty >- $object->make_column_dirty('firstname'); >+ is( $object->make_column_dirty('firstname'), '', 'make_column_dirty returns empty string on success' ); >+ is( $object->make_column_dirty('firstname'), 1, 'make_column_dirty returns 1 if already dirty' ); > is( $object->is_changed, 1, "Object is changed after make dirty" ); > $object->store; > is( $object->is_changed, 0, "Store clears dirty mark" ); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18725
:
64803
|
65625
|
68602
|
68603
|
70805
|
70826
|
70853
|
70876
|
73277
|
73278
|
73749
|
73750
|
73751
|
74143
| 74247