Attachment 7434 Details for Bug 7355 – [PASSED_QA] Patch

[patch] [PASSED_QA] Patch

patch.txt (text/plain), 2.31 KB, created by Marcel de Rooy on 2012-02-03 10:19:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2012-02-03 10:19:57 UTC

Size: 2.31 KB

patch

obsolete

>From 525056696edb5f3ceaac6c1f6602768b4fa39c91 Mon Sep 17 00:00:00 2001
>From: =?utf-8?q?Fr=C3=A9d=C3=A9ric=20Demians?= <f.demians@tamil.fr>
>Date: Wed, 14 Dec 2011 08:52:32 +0100
>Subject: [PATCH] Bug 7355 Note subfields are not displayed in TEXTAREA if hidden
>Content-Type: text/plain; charset="utf-8"
>
>In the data entry form, there is a (hidden) functionality for note subfields.
>MARC21 500-599 and UNIMARC 300-399 subfields are displayed in TEXTAREA rather
>than INPUT tags. This is good since usually notes can be pretty long. But if
>one of those fields is marked in the framework as 'hidden', then it isn't
>displayed at first when you create a record and when you expand the field by
>clicking on its label the field is displayed in a one-line INPUT tag.
>
>To reproduce this bug:
>
>- Modify your framework:
>  MARC21: 500$a, hidden=1
>  UNIMARC: 300$a, hidden=1
>- Create a new biblio record with this framework
>- Open the tab containing 500 or 300 field
>- 500 or 300 tab is collapsed
>- Click on 500 or 300 label to expand the field
>- 500$a or 300$a is displayed in a one-line INPUT tag, not in a TEXTAREA
>  as it should
>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Test plan works. Also checked cloning and deleting
>subfields still works.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Works as advertised. Simplifies code too. Well documented test plan.
>---
> cataloguing/addbiblio.pl |   15 +--------------
> 1 files changed, 1 insertions(+), 14 deletions(-)
>
>diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl
>index 568007e..f29e410 100755
>--- a/cataloguing/addbiblio.pl
>+++ b/cataloguing/addbiblio.pl
>@@ -467,21 +467,8 @@ sub create_input {
>                     value=\"$value\" \/>
>             ";
>     }
>-    elsif ( $tagslib->{$tag}->{$subfield}->{'hidden'} ) {
>-        $subfield_data{marc_value} =
>-            "<input type=\"text\"
>-                    id=\"".$subfield_data{id}."\"
>-                    name=\"".$subfield_data{id}."\"
>-                    class=\"input_marceditor\"
>-                    tabindex=\"1\"
>-                    size=\"67\"
>-                    maxlength=\"$max_length\"
>-                    value=\"$value\"
>-            \/>";
>-
>-        # it's a standard field
>-    }
>     else {
>+        # it's a standard field
>         if (
>             length($value) > 100
>             or
>-- 
>1.6.0.6
>

Actions: View | Diff | Splinter Review

Attachments on bug 7355: 6776 | 6830 | 6846 | 7434