Bugzilla – Attachment 74433 Details for
Bug 20343
Show number of checkouts by itemtype in circulation.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20343: Put translatable strings in strings.tt
Bug-20343-Put-translatable-strings-in-stringstt.patch (text/plain), 2.72 KB, created by
Julian Maurice
on 2018-04-18 13:25:05 UTC
(
hide
)
Description:
Bug 20343: Put translatable strings in strings.tt
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2018-04-18 13:25:05 UTC
Size:
2.72 KB
patch
obsolete
>From 894956350584c1f40a094524aad5eafd6de76a73 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Wed, 18 Apr 2018 15:20:02 +0200 >Subject: [PATCH] Bug 20343: Put translatable strings in strings.tt > >Also add a CSS class on <details> for easier styling and change the >list style so it take less space on screen >--- > koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 5 +++++ > koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc | 2 ++ > koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 5 +++-- > 3 files changed, 10 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/css/staff-global.css >index 310e84dd76..868a596a9b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/staff-global.css >+++ b/koha-tmpl/intranet-tmpl/prog/css/staff-global.css >@@ -1092,6 +1092,11 @@ span.expired { > font-style : italic; > } > >+details.checkouts-by-itemtype li { >+ display: inline-block; >+ margin-right: 1em; >+} >+ > div.help { > margin: .9em 0 0 0; > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc >index e116204cdc..e7c68d751c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc >@@ -43,5 +43,7 @@ > var SUSPEND_HOLD_ERROR_NOT_FOUND = _("Unable to suspend hold, hold not found"); > var RESUME_HOLD_ERROR_NOT_FOUND = _("Unable to resume, hold not found"); > var CURRENT = _(" (current) "); >+ var MSG_NO_ITEMTYPE = _("No itemtype"); >+ var MSG_CHECKOUTS_BY_ITEMTYPE = _("Number of checkouts by item type"); > //]]> > </script> >diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >index 5718bbc8dd..d6cd4b8fb4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >@@ -497,12 +497,13 @@ $(document).ready(function() { > var ul = $('<ul>'); > Object.keys(checkoutsByItype).sort().forEach(function (itype) { > var li = $('<li>') >- .append($('<strong>').html(itype || _("No itemtype"))) >+ .append($('<strong>').html(itype || MSG_NO_ITEMTYPE)) > .append(': ' + checkoutsByItype[itype]); > ul.append(li); > }) > $('<details>') >- .append($('<summary>').html(_("Number of checkouts by item type"))) >+ .addClass('checkouts-by-itemtype') >+ .append($('<summary>').html(MSG_CHECKOUTS_BY_ITEMTYPE)) > .append(ul) > .insertBefore(oSettings.nTableWrapper) > }, >-- >2.14.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20343
:
72482
|
72671
|
72672
|
72675
|
73475
|
74430
|
74431
|
74432
| 74433