Bugzilla – Attachment 74494 Details for
Bug 20568
Add API key management interface for patrons
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20568: (QA follow-up) Make sure client_id and secret are not overwritten on store
Bug-20568-QA-follow-up-Make-sure-clientid-and-secr.patch (text/plain), 1011 bytes, created by
Julian Maurice
on 2018-04-18 18:13:39 UTC
(
hide
)
Description:
Bug 20568: (QA follow-up) Make sure client_id and secret are not overwritten on store
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2018-04-18 18:13:39 UTC
Size:
1011 bytes
patch
obsolete
>From 848244b982e254d80fcc37b2856e600172c514fb Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 18 Apr 2018 13:56:28 -0300 >Subject: [PATCH] Bug 20568: (QA follow-up) Make sure client_id and secret are > not overwritten on store > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > Koha/ApiKey.pm | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/Koha/ApiKey.pm b/Koha/ApiKey.pm >index 08b661be02..716dd0efc2 100644 >--- a/Koha/ApiKey.pm >+++ b/Koha/ApiKey.pm >@@ -49,8 +49,10 @@ sub store { > > my ( $uuid, $uuidstring ); > >- $self->client_id($self->_generate_unused_uuid('client_id')); >- $self->secret($self->_generate_unused_uuid('secret')); >+ $self->client_id($self->_generate_unused_uuid('client_id')) >+ unless $self->client_id; >+ $self->secret($self->_generate_unused_uuid('secret')) >+ unless $self->secret; > > return $self->SUPER::store(); > } >-- >2.14.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20568
:
74179
|
74180
|
74229
|
74230
|
74231
|
74232
|
74233
|
74234
|
74235
|
74236
|
74248
|
74254
|
74255
|
74256
|
74257
|
74258
|
74259
|
74343
|
74344
|
74345
|
74346
|
74347
|
74348
|
74388
|
74389
|
74434
|
74454
|
74476
|
74477
|
74478
|
74479
|
74480
|
74481
|
74482
|
74486
|
74487
|
74488
|
74489
|
74490
|
74491
|
74492
|
74493
| 74494 |
74495
|
74496
|
74980
|
74981
|
75023
|
75186
|
75187
|
75188