Bugzilla – Attachment 74624 Details for
Bug 19873
Make it possible to search on value 0
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19873: (QA follow-up) Prevent warnings
Bug-19873-QA-follow-up-Prevent-warnings.patch (text/plain), 1.36 KB, created by
Julian Maurice
on 2018-04-20 12:36:10 UTC
(
hide
)
Description:
Bug 19873: (QA follow-up) Prevent warnings
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2018-04-20 12:36:10 UTC
Size:
1.36 KB
patch
obsolete
>From c76ec59d07c2ffa2f063d73d705af33da82227dd Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Fri, 20 Apr 2018 13:55:50 +0200 >Subject: [PATCH] Bug 19873: (QA follow-up) Prevent warnings > >"Use of uninitialized value $operands[X] in string ne" > >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > C4/Search.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Search.pm b/C4/Search.pm >index 99953b2678..f474271b5e 100644 >--- a/C4/Search.pm >+++ b/C4/Search.pm >@@ -1532,7 +1532,7 @@ sub buildQuery { > for ( my $i = 0 ; $i <= @operands ; $i++ ) { > > # COMBINE OPERANDS, INDEXES AND OPERATORS >- if ( $operands[$i] ne '' ) { >+ if ( ($operands[$i] // '') ne '' ) { > $operands[$i]=~s/^\s+//; > > # A flag to determine whether or not to add the index to the query >@@ -1677,7 +1677,7 @@ sub buildQuery { > query_desc => $query_desc, > operator => ($operators[ $i - 1 ]) ? $operators[ $i - 1 ] : '', > parsed_operand => $operand, >- original_operand => ($operands[$i] ne '') ? $operands[$i] : '', >+ original_operand => $operands[$i] // '', > index => $index, > index_plus => $index_plus, > indexes_set => $indexes_set, >-- >2.14.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19873
:
70122
|
72307
|
72839
|
72840
|
74622
|
74623
| 74624