Attachment 74668 Details for Bug 20456 – Bug 20456: Remove the C4::Serials::GetSubscriptionsFromBorrower

[patch] Bug 20456: Remove the C4::Serials::GetSubscriptionsFromBorrower

Bug-20456-Remove-the-C4SerialsGetSubscriptionsFrom.patch (text/plain), 2.23 KB, created by Katrin Fischer on 2018-04-20 21:46:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2018-04-20 21:46:43 UTC

Size: 2.23 KB

patch

obsolete

>From 22e4bea27c3e51e6cfe16ef077e947e6283791cd Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Fri, 16 Mar 2018 10:13:19 +0100
>Subject: [PATCH] Bug 20456: Remove the
> C4::Serials::GetSubscriptionsFromBorrower
>
>Bug 20400 added a routing list tab to the patron account in the
>OPAC using Koha::Object. After changing the staff view too,
>we can now safely remove GetSubscriptionsFromBorrower as it
>is no longer used.
>
>To test:
>- Make sure that GetSubscriptionsFromBorrower is no longer used.
>---
> C4/Serials.pm | 36 ------------------------------------
> 1 file changed, 36 deletions(-)
>
>diff --git a/C4/Serials.pm b/C4/Serials.pm
>index ac21dad..0f6256e 100644
>--- a/C4/Serials.pm
>+++ b/C4/Serials.pm
>@@ -85,7 +85,6 @@ BEGIN {
>       &check_routing &updateClaim
>       &CountIssues
>       HasItems
>-      &GetSubscriptionsFromBorrower
>       &subscriptionCurrentlyOnOrder
> 
>     );
>@@ -2198,41 +2197,6 @@ sub in_array {    # used in next sub down
>     return 0;
> }
> 
>-=head2 GetSubscriptionsFromBorrower
>-
>-($count,@routinglist) = GetSubscriptionsFromBorrower($borrowernumber)
>-
>-this gets the info from subscriptionroutinglist for each $subscriptionid
>-
>-return :
>-a count of the serial subscription routing lists to which a patron belongs,
>-with the titles of those serial subscriptions as an array. Each element of the array
>-contains a hash_ref with subscriptionID and title of subscription.
>-
>-=cut
>-
>-sub GetSubscriptionsFromBorrower {
>-    my ($borrowernumber) = @_;
>-    my $dbh              = C4::Context->dbh;
>-    my $sth              = $dbh->prepare(
>-        "SELECT subscription.subscriptionid, biblio.title
>-            FROM subscription
>-            JOIN biblio ON biblio.biblionumber = subscription.biblionumber
>-            JOIN subscriptionroutinglist USING (subscriptionid)
>-            WHERE subscriptionroutinglist.borrowernumber = ? ORDER BY title ASC
>-                               "
>-    );
>-    $sth->execute($borrowernumber);
>-    my @routinglist;
>-    my $count = 0;
>-    while ( my $line = $sth->fetchrow_hashref ) {
>-        $count++;
>-        push( @routinglist, $line );
>-    }
>-    return ( $count, @routinglist );
>-}
>-
>-
> =head2 GetFictiveIssueNumber
> 
> $issueno = GetFictiveIssueNumber($subscription, $publishedate);
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 20456: 73119 | 73120 | 74667 | 74668 | 74675 | 74683 | 74684 | 74685