Attachment 7469 Details for Bug 7505 – Proposed patch

[patch] Proposed patch

0001-Bug-7505-Superlibrarian-can-t-export-all-biblios-whe.patch (text/plain), 1.68 KB, created by Frédéric Demians on 2012-02-06 19:06:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Frédéric Demians

Created: 2012-02-06 19:06:46 UTC

Size: 1.68 KB

patch

obsolete

>From 4f821a0a8ec4938ad10b5546659ab7623808a291 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Demians?= <f.demians@tamil.fr>
>Date: Mon, 6 Feb 2012 20:00:24 +0100
>Subject: [PATCH] Bug 7505 Superlibrarian can't export all biblios when
> IndependantBranches is enabled
>
>When a Koha user has superlibrarian permissions, and if
>IndependantBranches is enabled, in Tools > Export bibliographic and
>holdings, this user can't export all biblio records. He will just export
>the biblio from the branch he belongs to.
>
>This patch fix that.
>
>To test:
>
>  - Do a ALL records export as superlibrian on a multi-branches Koha instance
>  - Examine the resulting MARC file with the tool of your choice (MArcEdit,
>    yaz-marcdump, etc.)
>  - You will see that 952/995 contains exlusively items from your branch (as
>    Koha user)
>---
> tools/export.pl |    5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/tools/export.pl b/tools/export.pl
>index 66763d6..d3d8646 100755
>--- a/tools/export.pl
>+++ b/tools/export.pl
>@@ -47,11 +47,12 @@ my ($template, $loggedinuser, $cookie)
> 
> 	my $limit_ind_branch=(C4::Context->preference('IndependantBranches') &&
>               C4::Context->userenv &&
>-              C4::Context->userenv->{flags} % 2 !=1  &&
>+              !(C4::Context->userenv->{flags} & 1) &&
>               C4::Context->userenv->{branch}?1:0);
> 	my $branches = GetBranches($limit_ind_branch);    
>     my $branch                = $query->param("branch") || '';
>-	if ( C4::Context->preference("IndependantBranches") ) {
>+	if ( C4::Context->preference("IndependantBranches") &&
>+         !(C4::Context->userenv->{flags} & 1) ) {
>     	$branch = C4::Context->userenv->{'branch'};
> 	}
> 
>-- 
>1.7.8
>

Actions: View | Diff | Splinter Review

Attachments on bug 7505: 7469 | 7476