Bugzilla – Attachment 74695 Details for
Bug 20103
Readonly::XS version not detected
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20103: Readonly::XS is completely bogus post perl 5.8
Bug-20103-ReadonlyXS-is-completely-bogus-post-perl.patch (text/plain), 1.15 KB, created by
Katrin Fischer
on 2018-04-22 16:14:10 UTC
(
hide
)
Description:
Bug 20103: Readonly::XS is completely bogus post perl 5.8
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2018-04-22 16:14:10 UTC
Size:
1.15 KB
patch
obsolete
>From 5a137473839115e773387e20779f79f505bb115c Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Wed, 28 Mar 2018 22:40:09 +0000 >Subject: [PATCH] Bug 20103: Readonly::XS is completely bogus post perl 5.8 > >A ha! Lie about who we are, and the module will return a version. > >./koha_perl_deps.pl -a >-- before patch Readonly::XS is 0 >-- after patch it has a version number. >run koha qa test tools > >Signed-off-by: Victor Grousset <victor.grousset@biblibre.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > C4/Installer/PerlModules.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/Installer/PerlModules.pm b/C4/Installer/PerlModules.pm >index 35cbfeb..affcd78 100644 >--- a/C4/Installer/PerlModules.pm >+++ b/C4/Installer/PerlModules.pm >@@ -78,6 +78,7 @@ sub version_info { > my ( $self, $module ) = @_; > return -1 unless grep { /^$module$/ } keys(%$PERL_DEPS); > >+ $Readonly::XS::MAGIC_COOKIE="Do NOT use or require Readonly::XS unless you're me."; > eval "require $module"; > my $pkg_version = $module->can("VERSION") ? $module->VERSION : 0; > my $min_version = $PERL_DEPS->{$module}->{'min_ver'} // 0; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20103
:
71071
|
72546
|
73406
|
73407
|
73879
| 74695