Attachment 74760 Details for Bug 1985 – Bug 1985: Fix whitespace in opac/opac-review.pl

[patch] Bug 1985: Fix whitespace in opac/opac-review.pl

Bug-1985-Fix-whitespace-in-opacopac-reviewpl.patch (text/plain), 2.14 KB, created by Mark Tompsett on 2018-04-23 18:14:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2018-04-23 18:14:37 UTC

Size: 2.14 KB

patch

obsolete

>From 09ec667b0d7bfa185b4b656a72ec201d8086c889 Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Fri, 26 May 2017 09:52:44 -0400
>Subject: [PATCH] Bug 1985: Fix whitespace in opac/opac-review.pl
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>$ git diff -w origin/master
>-- should have no differences
>
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>---
> opac/opac-review.pl | 32 ++++++++++++++++----------------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
>diff --git a/opac/opac-review.pl b/opac/opac-review.pl
>index b4a26be..f6284fb 100755
>--- a/opac/opac-review.pl
>+++ b/opac/opac-review.pl
>@@ -61,19 +61,19 @@ if( !$biblio ) {
> }
> 
> if( !@errors && defined $review ) {
>-	if ($review !~ /\S/) {
>-		push @errors, {empty=>1};
>-	} else {
>-		$clean = C4::Scrubber->new('comment')->scrub($review);
>-		if ($clean !~ /\S/) {
>-			push @errors, {scrubbed_all=>1};
>-		} else {
>-			if ($clean ne $review) {
>-				push @errors, {scrubbed=>$clean};
>-			}
>-			my $js_ok_review = $clean;
>-			$js_ok_review =~ s/"/&quot;/g;	# probably redundant w/ TMPL ESCAPE=JS
>-			$template->param(clean_review=>$js_ok_review);
>+    if ($review !~ /\S/) {
>+        push @errors, {empty=>1};
>+    } else {
>+        $clean = C4::Scrubber->new('comment')->scrub($review);
>+        if ($clean !~ /\S/) {
>+            push @errors, {scrubbed_all=>1};
>+        } else {
>+            if ($clean ne $review) {
>+                push @errors, {scrubbed=>$clean};
>+            }
>+            my $js_ok_review = $clean;
>+            $js_ok_review =~ s/"/&quot;/g;    # probably redundant w/ TMPL ESCAPE=JS
>+            $template->param(clean_review=>$js_ok_review);
>             if ($savedreview) {
>                 $savedreview->set(
>                     {
>@@ -91,9 +91,9 @@ if( !@errors && defined $review ) {
>                     }
>                 )->store->reviewid;
>             }
>-			unless (@errors){ $template->param(WINDOW_CLOSE=>1); }
>-		}
>-	}
>+            unless (@errors){ $template->param(WINDOW_CLOSE=>1); }
>+        }
>+    }
> }
> (@errors   ) and $template->param(   ERRORS=>\@errors);
> ($cgi_debug) and $template->param(cgi_debug=>1       );
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 1985: 33916 | 33918 | 36065 | 36516 | 36517 | 36521 | 36522 | 36613 | 36614 | 36628 | 36629 | 36643 | 36644 | 36645 | 36677 | 36678 | 36720 | 38908 | 38909 | 38910 | 39062 | 63746 | 63747 | 63748 | 63749 | 63750 | 63751 | 63752 | 63761 | 63762 | 63763 | 74760 | 74761 | 74762 | 74763 | 74764 | 74769 | 74770 | 74771 | 91190 | 91191 | 91192 | 91193 | 91194 | 91195 | 91196 | 91197 | 91198 | 91818 | 91819 | 91820 | 91821 | 91822 | 91823