Bugzilla – Attachment 74766 Details for
Bug 20616
Using "Edit serials" with no issues selected gives an ugly error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20616: Prevent "edit serials" form submission if no serial is selected
Bug-20616-Prevent-edit-serials-form-submission-if-.patch (text/plain), 1.59 KB, created by
Jonathan Druart
on 2018-04-23 19:21:43 UTC
(
hide
)
Description:
Bug 20616: Prevent "edit serials" form submission if no serial is selected
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-04-23 19:21:43 UTC
Size:
1.59 KB
patch
obsolete
>From 9f619765779dd2b5814b03fb9b7671abcceceb26 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 23 Apr 2018 16:19:50 -0300 >Subject: [PATCH] Bug 20616: Prevent "edit serials" form submission if no > serial is selected > >In order to prevent the form to submit and gives an ugly error if no >issues are selected we will make sure at least one is checked otherwise >an alert will be displayed. > >Test plan: >- create a subscrpition >- go to the serials collection page >- don't check any checkboxes for serials >- click 'Edit serials' >--- > .../intranet-tmpl/prog/en/modules/serials/serials-collection.tt | 9 +++++++++ > 1 file changed, 9 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >index a5e1b1e05f..64c856eb86 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >@@ -320,6 +320,15 @@ > $('#multi_receiving').on('show', function () { > $(this).find(".modal-body").html($(".serials_multi_receiving")[0].outerHTML); > }); >+ >+ $("form[name='edition']").on('submit', function(e){ >+ if ( $(this).find("input[name='serialid']:checked").size() == 0 ) { >+ e.preventDefault(); >+ alert("You must select at least one serial to edit"); >+ return 0; >+ } >+ return 1; >+ }); > }); > > </script> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20616
:
74766
|
74768
|
74772
|
74773