Bugzilla – Attachment 74802 Details for
Bug 19171
Confusing message "no items available" when placing a hold in OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19171: Attempt to make "no holds possible" messages less confusing
Bug-19171-Attempt-to-make-no-holds-possible-messag.patch (text/plain), 3.98 KB, created by
Owen Leonard
on 2018-04-24 12:59:39 UTC
(
hide
)
Description:
Bug 19171: Attempt to make "no holds possible" messages less confusing
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2018-04-24 12:59:39 UTC
Size:
3.98 KB
patch
obsolete
>From 1c3e42fcf56176a515313ecbc781b61b795f0b26 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sun, 22 Apr 2018 22:00:17 +0000 >Subject: [PATCH] Bug 19171: Attempt to make "no holds possible" messages less > confusing > >At the moment, when no holds are possible, the OPAC reads something >like: > >Sorry, none of these items can be placed on hold. >No items available. > >This is confusing to the patrons, because the records have items, >but they are not showing. The record also may have available items, >they are just not permitted to place holds on them. > >Changes: >- Only display the first message, when somoene tried unsuccessfully > to place holds on multiple records. >- Change first message to: Sorry, none of these titles can be placed on hold. >- Change the second message to read: > No items available to be placed on hold. >- Remove <strong> around Sorry for better translatability. > >To test: >- Try to place a hold on single record, where no hold is possible. >- Try to place a hold on a single record, where a hold is possible. >- Try to place holds on multiple records where no hold is possible. >- Try to place holds on multiple records where at least one hold > is possible. > > Verify the screen messages make sense in all cases. > >https://bugs.koha-community.org/show_bug.cgi?id=14716 > >Fixed stray </strong> during signoff. >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 8 ++++---- > opac/opac-reserve.pl | 4 ++++ > 2 files changed, 8 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >index 0f2f4eb..4d7aa9d 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >@@ -22,7 +22,7 @@ > <div id="holds"> > [% IF ( message ) %] > <div id="holdmessages" class="alert"> >- <p><strong>Sorry</strong>, you cannot place holds.</strong></p> >+ <p>Sorry, you cannot place holds.</p> > <ul> > [% IF ( GNA ) %] > <li id="gna"> >@@ -106,9 +106,9 @@ > > [% ELSE %] > >- [% IF ( none_available ) %] >+ [% IF ( none_available && multi_holds ) %] > <div id="none_available" class="alert"> >- <strong>Sorry</strong>, none of these items can be placed on hold. >+ Sorry, none of these titles can be placed on hold. > </div> > [% END %] > </div> >@@ -174,7 +174,7 @@ > <div class="alert">You have already requested this title.</div> > [% ELSE %] > [% UNLESS ( bibitemloo.bib_available ) %] >- <div class="alert">No available items.</div> >+ <div class="alert">There are no items that can be placed on hold.</div> > [% ELSE %] > [% IF ( bibitemloo.already_patron_possession ) %] > <div class="alert">This title cannot be requested because it's already in your possession.</div> >diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl >index 2be6991..7f71638 100755 >--- a/opac/opac-reserve.pl >+++ b/opac/opac-reserve.pl >@@ -623,6 +623,10 @@ if ( $numBibsAvailable == 0 || $anyholdable == 0) { > $template->param( none_available => 1 ); > } > >+if (scalar @biblionumbers > 1) { >+ $template->param( multi_holds => 1); >+} >+ > my $show_notes=C4::Context->preference('OpacHoldNotes'); > $template->param(OpacHoldNotes=>$show_notes); > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19171
:
74710
|
74802
|
75059