Bugzilla – Attachment 74856 Details for
Bug 20659
Blocking errors are not longer displayed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20659: Fix blocking errors display
Bug-20659-Fix-blocking-errors-display.patch (text/plain), 1.45 KB, created by
Jonathan Druart
on 2018-04-25 19:53:08 UTC
(
hide
)
Description:
Bug 20659: Fix blocking errors display
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-04-25 19:53:08 UTC
Size:
1.45 KB
patch
obsolete
>From caac1cd54eae5e3e24251f61c0a60182b8a17362 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 25 Apr 2018 16:52:07 -0300 >Subject: [PATCH] Bug 20659: Fix blocking errors display > >The include file blocking-errors.inc has been created to by-pass regular >processing and display an error that should block the elements of the >view. > >For instance you call a patron's page with invalid borrowernumber => we >do not want the app to crash (500) or the page to display with broken >elements. > >It worked well on bug 18403 but it's now broken, a blank page is >displayed instead. >It may be caused by the move of the JS to the bottom of the page. > >Test plan: >hit /cgi-bin/koha/members/moremember.pl?borrowernumber=45432 >Without this patch a blank page is displayed. >With this patch you see the blocking error >--- > koha-tmpl/intranet-tmpl/prog/en/includes/blocking_errors.inc | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/blocking_errors.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/blocking_errors.inc >index 2d25a16da0..4be8110e46 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/blocking_errors.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/blocking_errors.inc >@@ -6,5 +6,6 @@ > [% CASE %][% blocking_error %] > [% END %] > >+ [% INCLUDE 'intranet-bottom.inc' %] > [% STOP %] [%# Will stop gracefully without processing any more of the template document.%] > [% END %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20659
: 74856