Attachment 74908 Details for Bug 20444 – Bug 20444: Remove sub GetAttributes

[patch] Bug 20444: Remove sub GetAttributes

Bug-20444-Remove-sub-GetAttributes.patch (text/plain), 1.41 KB, created by Marcel de Rooy on 2018-04-27 08:39:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2018-04-27 08:39:46 UTC

Size: 1.41 KB

patch

obsolete

>From 5ae0bc9b17024ebebb4c8ab54f6590750b330b1e Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Mon, 19 Mar 2018 09:33:50 +0000
>Subject: [PATCH] Bug 20444: Remove sub GetAttributes
>MIME-Version: 1.0
>Content-Type: text/plain; charset=utf-8
>Content-Transfer-Encoding: 8bit
>Content-Type: text/plain; charset=utf-8
>
>0) Apply this patch
>1) git grep GetAttributes should return no occurencies
>
>Signed-off-by: SÃ©verine QUEUNE <severine.queune@bulac.fr>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> C4/Members/Attributes.pm | 18 ------------------
> 1 file changed, 18 deletions(-)
>
>diff --git a/C4/Members/Attributes.pm b/C4/Members/Attributes.pm
>index ab43a7c..cf9051d 100644
>--- a/C4/Members/Attributes.pm
>+++ b/C4/Members/Attributes.pm
>@@ -95,24 +95,6 @@ sub GetBorrowerAttributes {
>     return \@results;
> }
> 
>-=head2 GetAttributes
>-
>-  my $attributes = C4::Members::Attributes::GetAttributes([$opac_only]);
>-
>-Retrieve an arrayref of extended attribute codes
>-
>-=cut
>-
>-sub GetAttributes {
>-    my ($opac_only) = @_;
>-
>-    my $dbh = C4::Context->dbh();
>-    my $query = "SELECT code FROM borrower_attribute_types";
>-    $query .= "\nWHERE opac_display = 1" if $opac_only;
>-    $query .= "\nORDER BY code";
>-    return $dbh->selectcol_arrayref($query);
>-}
>-
> =head2 GetBorrowerAttributeValue
> 
>   my $value = C4::Members::Attributes::GetBorrowerAttributeValue($borrowernumber, $attribute_code);
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 20444: 73083 | 73084 | 73085 | 74788 | 74789 | 74790 | 74793 | 74794 | 74795 | 74906 | 74907 | 74908