Bugzilla – Attachment 74909 Details for
Bug 19469
Add ability to split view of holds view on record by pickup library and/or itemtype
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19469 [QA Followup]: When altering priorities, use the existing priority numbers of the given table
Bug-19469-QA-Followup-When-altering-priorities-use.patch (text/plain), 1.86 KB, created by
Kyle M Hall (khall)
on 2018-04-27 09:22:08 UTC
(
hide
)
Description:
Bug 19469 [QA Followup]: When altering priorities, use the existing priority numbers of the given table
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2018-04-27 09:22:08 UTC
Size:
1.86 KB
patch
obsolete
>From 0dff7aa5dc1e09ad85194601245062ec7974cbdb Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 27 Apr 2018 09:21:28 +0000 >Subject: [PATCH] Bug 19469 [QA Followup]: When altering priorities, use the > existing priority numbers of the given table > >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index a8558e3846..d01452f5e5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -164,24 +164,33 @@ function checkMultiHold() { > } > }); > var prev_rank_request; >+ var priorities; > $("select[name=rank-request]").on("focus", function() { > prev_rank_request = $(this).val(); >+ >+ var row = $(this).parents("tr:first"); >+ priorities = row.parent().find("select[name=rank-request]").map( function() { >+ return $(this).val(); >+ }).get(); > }).change(function() { > var row = $(this).parents("tr:first"); >+ > var value = parseInt($(this).val()); > var rowsCount = row.parent().children('tr').length - 1; > value = value > rowsCount ? rowsCount : value; > var after = row.parent().find("tr:nth-child("+(value+1)+")"); > >+ >+ > if (prev_rank_request > value) { > row.insertBefore(after); > } else { > row.insertAfter(after); > } > >- var next_priority = 1; >+ var next_priority = 0; > row.parent().find("select[name=rank-request]").each(function () { >- $(this).val(next_priority); >+ $(this).val(priorities[next_priority]); > next_priority++; > }); > }); >-- >2.15.1 (Apple Git-101)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19469
:
68166
|
68167
|
68168
|
68169
|
68347
|
68348
|
68609
|
72304
|
72305
|
72441
|
72442
|
72443
|
72501
|
74260
|
74328
|
74329
|
74330
|
74331
|
74332
|
74333
|
74334
|
74909
|
78506
|
78507
|
78508
|
78509
|
78510
|
78511
|
78512
|
78513
|
78526
|
78529
|
78707
|
81828
|
81829