Attachment 75022 Details for Bug 20685 – Bug 20685: Escape letter template content in textarea

[patch] Bug 20685: Escape letter template content in textarea

Bug-20685-Escape-letter-template-content-in-textar.patch (text/plain), 2.21 KB, created by Jonathan Druart on 2018-05-03 18:41:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-05-03 18:41:31 UTC

Size: 2.21 KB

patch

obsolete

>From 6709e081ca2266e5f53cdf1c289c86cd39421e06 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 3 May 2018 15:40:11 -0300
>Subject: [PATCH] Bug 20685: Escape letter template content in textarea
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Test plan:
>enter the following text into the Email template for 'HOLD_SLIP'
>in Home âº Tools âº Notices & Slips âº Modify notice
>
><div style='max-width: 4in;'>
><h3><<borrowers.surname>>, <<borrowers.firstname>></h3><br />
><<borrowers.streetnumber>> <<borrowers.address>><br />
><<borrowers.address2>><br />
><<borrowers.city>>, <<borrowers.state>> <<borrowers.zipcode>><br />
><br />
><br />
><img src="/cgi-bin/koha/svc/barcode?barcode=<<borrowers.cardnumber>>&type=Industrial2of5&notext=1">
>
>Edit it again
>Without this patch you will get:
><img src="/cgi-bin/koha/svc/barcode?barcode=<<borrowers.cardnumber>>&type=Industrial2of5Â¬ext=1">
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
>index d7cfab2862..71494995b4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
>@@ -360,7 +360,7 @@
>                         <td class="actions">
>                             <button type="button" data-containerid="[% letter.message_transport_type %]_[% lang %]" class="btn btn-default btn-sm insert">Insert <i class="fa fa-long-arrow-right"></i></button>
>                         </td>
>-                      <td><textarea name="content" data-lang="[% lang %]" class="content_[% letter.message_transport_type %]" id="content_[% letter.message_transport_type %]_[% lang %]" cols="80" rows="15">[% letter.content %]</textarea></td>
>+                      <td><textarea name="content" data-lang="[% lang %]" class="content_[% letter.message_transport_type %]" id="content_[% letter.message_transport_type %]_[% lang %]" cols="80" rows="15">[% letter.content | html %]</textarea></td>
>                     </tr>
>                   </table>
>                 </li>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20685: 75022 | 75039 | 75046