Bugzilla – Attachment 75085 Details for
Bug 15774
Additional fields for baskets
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15774: Fix additional fields filters
Bug-15774-Fix-additional-fields-filters.patch (text/plain), 4.29 KB, created by
Julian Maurice
on 2018-05-04 15:43:47 UTC
(
hide
)
Description:
Bug 15774: Fix additional fields filters
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2018-05-04 15:43:47 UTC
Size:
4.29 KB
patch
obsolete
>From dfaaf6ff16d3f038690721fd6b0306769ed9aef5 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Thu, 22 Feb 2018 13:52:10 +0100 >Subject: [PATCH] Bug 15774: Fix additional fields filters > >Addresses the following QA comments: > >1/ Regression: >On serials/serials-search.pl, the filters are not filled with what the >users searched for and the additional fields linked to an AV are not >displayed as a dropdown list. > >4/ When searching an order, there is no way not to set a "all" value for >additional fields linked to AV. > >5/ When searching an order and the search does not return any results, >the field should contain what the user filled in. > >https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774#c10 >--- > .../intranet-tmpl/prog/en/includes/additional-fields-entry.inc | 5 +++-- > .../intranet-tmpl/prog/en/modules/serials/serials-search.tt | 10 +++++----- > 2 files changed, 8 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-entry.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-entry.inc >index a961e55292..123e5b38c2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-entry.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-entry.inc >@@ -9,8 +9,9 @@ > <label for="additional_field_[% field.id %]"> [% field.name %]: </label> > [% IF field.authorised_value_category %] > <select name="additional_field_[% field.id %]" id="additional_field_[% field.id %]"> >- [% FOREACH av IN AuthorisedValues.Get( field.authorised_value_category, values.${field.name} ) %] >- [% IF av.selected %] >+ <option value="">All</option> >+ [% FOREACH av IN AuthorisedValues.GetAuthValueDropbox( field.authorised_value_category ) %] >+ [% IF av.authorised_value == values.${field.name} %] > <option value="[% av.authorised_value %]" selected="selected">[% av.lib %]</option> > [% ELSE %] > <option value="[% av.authorised_value %]">[% av.lib %]</option> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt >index 85c556383e..cf6fcf3f7f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt >@@ -355,11 +355,11 @@ > [% FOR field IN additional_fields_for_subscription %] > <li> > <label for="additional_field_[% field.id %]ID"> [% field.name %]: </label> >- [% IF field.authorised_value_choices %] >- <select id="additional_field_[% field.id %]" name="additional_field_[% field.id %]_filter"> >+ [% IF field.authorised_value_category %] >+ <select id="additional_field_[% field.id %]" name="additional_field_[% field.id %]"> > <option value="">All</option> >- [% FOREACH av IN field.authorised_value_choices %] >- [% IF av.authorised_value == additional_field_filters.${field.name}.value %] >+ [% FOREACH av IN AuthorisedValues.GetAuthValueDropbox(field.authorised_value_category) %] >+ [% IF av.authorised_value == additional_field_filters.${field.name} %] > <option value="[% av.authorised_value %]" selected="selected">[% av.lib %]</option> > [% ELSE %] > <option value="[% av.authorised_value %]">[% av.lib %]</option> >@@ -367,7 +367,7 @@ > [% END %] > </select> > [% ELSE %] >- <input id="additional_field_[% field.id %]" type="text" value="[% additional_field_filters.${field.name}.value %]" name="additional_field_[% field.id %]_filter" /> >+ <input id="additional_field_[% field.id %]" type="text" value="[% additional_field_filters.${field.name} %]" name="additional_field_[% field.id %]" /> > [% END %] > </li> > [% END %] >-- >2.14.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15774
:
48224
|
53608
|
53609
|
72078
|
72079
|
72085
|
72086
|
75083
|
75084
|
75085
|
75086
|
75336
|
75354
|
75361
|
79976
|
79977
|
79978
|
79979
|
79980
|
79981
|
79982
|
80060
|
80061
|
80062
|
80063
|
80064
|
80065
|
80066
|
80680
|
81490
|
81491
|
81492
|
81493
|
81494
|
81495
|
81496
|
81497
|
81833
|
81837
|
81838
|
81839
|
81840
|
81841
|
81842
|
81843
|
81844
|
81845
|
81846
|
81847
|
81848
|
81849
|
81850
|
81851
|
81852
|
83349
|
83350
|
83351
|
83352
|
83353
|
83354
|
83355
|
83356
|
83357
|
83358
|
83359
|
83360
|
83361
|
83362
|
83363
|
83364
|
83444
|
83445
|
83446
|
83447
|
83448
|
83449
|
83450
|
83451
|
83452
|
83453
|
83454
|
83455
|
83456
|
83457
|
83458
|
83459
|
85333
|
85334
|
85335
|
85336
|
85337
|
85338
|
85339
|
85340
|
85341
|
85342
|
85343
|
85344
|
85345
|
85346
|
85347
|
85348
|
85792
|
85806
|
85807
|
85808
|
85809
|
85810
|
85811
|
85812
|
85813
|
85814
|
85815
|
85816
|
85817
|
85818
|
85819
|
85820
|
85821
|
85822
|
85823
|
85824
|
86411