Attachment 75123 Details for Bug 12310 – Bug 12310: Fix decimal separators issues in fines: writeoff amount field

[patch] Bug 12310: Fix decimal separators issues in fines: writeoff amount field

Bug-12310-Fix-decimal-separators-issues-in-fines-w.patch (text/plain), 2.81 KB, created by Victor Grousset/tuxayo on 2018-05-07 13:22:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Grousset/tuxayo

Created: 2018-05-07 13:22:21 UTC

Size: 2.81 KB

patch

obsolete

>From 74632469245c96c627b8f7cbe6c6f9b2baf95304 Mon Sep 17 00:00:00 2001
>From: Victor Grousset <victor.grousset@biblibre.com>
>Date: Mon, 7 May 2018 14:31:53 +0200
>Subject: [PATCH] Bug 12310: Fix decimal separators issues in fines: writeoff
> amount field
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This is a follow up for this forgotten field.
>See main patch more details.
>
>== Test plan ==
>1. Use a translation of the staff interface if possible.
>2. Go to a patrons's page â fines â pay fines
>3. Click on "Write off"
>    This assumes an existing debt. Which should exists if you just
>    tested the previous patches.
>4. If you enter "1,50", the writeoff amount saved is only 1.
>     This is the bug.
>5. Apply this patch
>6. run ~/src/installer/data/mysql/updatedatabase.pl
>7. Refresh the page
>8. Retry the write off.
>     Apply the annex 1 to the "Writeoff amount" field
>9. It works! \o/
>
>=== Annex 1: Subpart for each concerned page ===
>1. Set DecimalSeparators syspref to ",."
>2. Input "12,34"
>3. Press the "Tab/Tabulation" key. It will unfocus the field and trigger the
>     conversion. Validating the form does the same but it's a trick to test more
>     quickly by not switching to another page.
>4. The value should have been converted to 12.34
>5. Do the same with "12,34 EUR" and ensure that it's converted to "12,34"
>   Same with "EUR 12.34" -> "12.34"
>6. "EUR 12.34â¬thanks lyonthree" -> "12.34"
>7. "123 456,7" -> "123456.7"
>8.. "2" -> "2"
>9.. "2,0" -> "2.0"
>10. "-1'345.95" -> "-1345.95"
>11. ",1234" -> ".1234"
>12. Set DecimalSeparators syspref to ","
>13. Reload the page with the form
>14. "1.000" -> "1000"
>15. "1.000.000,10" -> "1000000.10"
>16. Set DecimalSeparators syspref to "."
>17. Reload the page with the form
>18. "1,000" -> "1000"
>19. "1,000,000.10" -> "1000000.10"
>20. Validate the form and check that the final value with the dot was
>21    well handled.
>22. Think about Koalas and smile. ð¨ð¨ð¨
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
>index 3e1ad4f..3803946 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
>@@ -139,7 +139,7 @@
>                 <li>
>                     <label for="paid">Writeoff amount: </label>
>                     
>-                    <input name="amountwrittenoff" id="amountwrittenoff" value="[% amountoutstanding %]" />
>+                    <input name="amountwrittenoff" id="amountwrittenoff" class="decimal-unformating" value="[% amountoutstanding %]" />
>                 </li>
>             </ol>
>         </fieldset>
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 12310: 28455 | 60530 | 60563 | 61357 | 61603 | 61604 | 62655 | 64671 | 64672 | 64673 | 64674 | 64675 | 64678 | 64679 | 64696 | 72104 | 72213 | 72983 | 73055 | 73215 | 73546 | 73657 | 73784 | 73785 | 73873 | 73874 | 73880 | 74524 | 74525 | 74526 | 74527 | 74528 | 74529 | 75123 | 75127 | 75128 | 75129 | 75130 | 75947 | 75948 | 75949 | 75950 | 75951 | 75952 | 75954 | 75955 | 75956 | 75957 | 75958 | 75959 | 76896 | 76933 | 77971 | 77972 | 77973 | 77995 | 78017 | 78631 | 78632 | 78633 | 78634 | 78635 | 78636 | 78637 | 78638