Bugzilla – Attachment 75136 Details for
Bug 20505
Selenium tests fail if server not running
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20505: Friendlier death message
Bug-20505-Friendlier-death-message.patch (text/plain), 2.24 KB, created by
Mark Tompsett
on 2018-05-07 16:03:43 UTC
(
hide
)
Description:
Bug 20505: Friendlier death message
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2018-05-07 16:03:43 UTC
Size:
2.24 KB
patch
obsolete
>From 58969824814b95b63979cb73ddb4c47822fbb07b Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Mon, 7 May 2018 15:51:33 +0000 >Subject: [PATCH] Bug 20505: Friendlier death message > >Actually telling the user where to look to solve the problem >is more helpful than just expecting them to know why the selenium >driver didn't load. > >prove t/db_dependent/selenium/ >--- > t/db_dependent/selenium/administration_tasks.t | 4 +++- > t/db_dependent/selenium/basic_workflow.t | 9 +++++++-- > 2 files changed, 10 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/selenium/administration_tasks.t b/t/db_dependent/selenium/administration_tasks.t >index 5f65b59..69fc9c1 100644 >--- a/t/db_dependent/selenium/administration_tasks.t >+++ b/t/db_dependent/selenium/administration_tasks.t >@@ -47,7 +47,9 @@ SKIP: { > try { > $s = t::lib::Selenium->new; > } catch { >- skip "Unable to create selenium driver link. Please review https://wiki.koha-community.org/wiki/Using_Selenium_with_Koha", 1; >+ diag "\nUnable to create selenium driver link. Please review https://wiki.koha-community.org/wiki/Using_Selenium_with_Koha"; >+ fail; >+ exit 0; > }; > > my $driver = $s->driver; >diff --git a/t/db_dependent/selenium/basic_workflow.t b/t/db_dependent/selenium/basic_workflow.t >index 325710a..f17da6f 100644 >--- a/t/db_dependent/selenium/basic_workflow.t >+++ b/t/db_dependent/selenium/basic_workflow.t >@@ -38,7 +38,7 @@ use Time::HiRes qw(gettimeofday); > use C4::Context; > use C4::Biblio qw( AddBiblio ); # We shouldn't use it > >-use Test::More tests => 20; >+use Test::More; > use MARC::Record; > use MARC::Field; > use Try::Tiny; >@@ -90,7 +90,10 @@ SKIP: { > try { > $s = t::lib::Selenium->new; > } catch { >- skip "Unable to create selenium driver link. Please review https://wiki.koha-community.org/wiki/Using_Selenium_with_Koha", 20; >+ diag "\nUnable to create selenium driver link. Please review https://wiki.koha-community.org/wiki/Using_Selenium_with_Koha"; >+ fail; >+ done_testing(); >+ exit 0; > }; > > open my $fh, '>>', '/tmp/output.txt'; >@@ -204,6 +207,8 @@ SKIP: { > $driver->quit(); > }; > >+done_testing(); >+ > END { > cleanup() if $cleanup_needed; > }; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20505
:
73517
|
74364
|
75054
| 75136