Bugzilla – Attachment 75221 Details for
Bug 20724
ReservesNeedReturns syspref breaks "Holds awaiting pickup"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20724: Correctly mark an hold as waiting - ReservesNeedReturns
Bug-20724-Correctly-mark-an-hold-as-waiting---Rese.patch (text/plain), 962 bytes, created by
Jonathan Druart
on 2018-05-10 14:42:37 UTC
(
hide
)
Description:
Bug 20724: Correctly mark an hold as waiting - ReservesNeedReturns
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-05-10 14:42:37 UTC
Size:
962 bytes
patch
obsolete
>From 665cee5eee0d60464bc8cf31a2a1dc26533dd34e Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatetsolutions.com> >Date: Thu, 10 May 2018 08:12:04 -0400 >Subject: [PATCH] Bug 20724: Correctly mark an hold as waiting - > ReservesNeedReturns > >We need to call Koha::Hold->set_waiting to correctly >calculate the expiration date. > >It fixes a regression introduced by > commit 26634151dbce0bf39ff6c9eda5b58bb993996a2d > Bug 12063 - Fix QA failures > >The expiration date has to be set for waiting holds >--- > C4/Reserves.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 73b86b606c..a919f7581c 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -203,6 +203,7 @@ sub AddReserve { > itemtype => $itemtype, > } > )->store(); >+ $hold->set_waiting() if $found eq 'W'; > > logaction( 'HOLDS', 'CREATE', $hold->id, Dumper($hold->unblessed) ) > if C4::Context->preference('HoldsLog'); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20724
:
75211
|
75219
|
75221
|
75222
|
75223
|
75307
|
75308
|
75309
|
75325
|
75363
|
75364
|
75365
|
75366
|
75367