Bugzilla – Attachment 75273 Details for
Bug 20623
PDF export of a basket group fails when an item has an itemtype that is not in the itemtype table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20623: (QA follow-up) avoid fetch() calls in some cases
Bug-20623-QA-follow-up-avoid-fetch-calls-in-some-c.patch (text/plain), 1.16 KB, created by
Victor Grousset/tuxayo
on 2018-05-11 15:47:50 UTC
(
hide
)
Description:
Bug 20623: (QA follow-up) avoid fetch() calls in some cases
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2018-05-11 15:47:50 UTC
Size:
1.16 KB
patch
obsolete
>From 09728f451b7875adaa65fec1d91553582ce4367e Mon Sep 17 00:00:00 2001 >From: Victor Grousset <victor.grousset@biblibre.com> >Date: Fri, 11 May 2018 17:43:33 +0200 >Subject: [PATCH] Bug 20623: (QA follow-up) avoid fetch() calls in some cases > >--- > acqui/basketgroup.pl | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >diff --git a/acqui/basketgroup.pl b/acqui/basketgroup.pl >index 92a58ac..78514ba 100755 >--- a/acqui/basketgroup.pl >+++ b/acqui/basketgroup.pl >@@ -194,9 +194,11 @@ sub printbasketgrouppdf{ > } > } > >- my $itemtype = Koha::ItemTypes->find( $biblioitem->itemtype ); >- my $item_has_type_description = $ord->{itemtype} && $biblioitem->itemtype && $itemtype; >- $ord->{itemtype} = $item_has_type_description ? $itemtype->description : undef; >+ my $itemtype = ( $ord->{itemtype} and $biblioitem->itemtype ) >+ ? Koha::ItemTypes->find( $biblioitem->itemtype ) >+ : undef; >+ $ord->{itemtype} = $itemtype ? $itemtype->description : undef; >+ > $ord->{en} = $en ? $en : undef; > $ord->{edition} = $edition ? $edition : undef; > >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20623
:
74604
|
74605
|
74913
|
75225
|
75263
|
75264
| 75273