Bugzilla – Attachment 75307 Details for
Bug 20724
ReservesNeedReturns syspref breaks "Holds awaiting pickup"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20724: Correctly mark an hold as waiting - ReservesNeedReturns
Bug-20724-Correctly-mark-an-hold-as-waiting---Rese.patch (text/plain), 2.04 KB, created by
Victor Grousset/tuxayo
on 2018-05-14 14:45:01 UTC
(
hide
)
Description:
Bug 20724: Correctly mark an hold as waiting - ReservesNeedReturns
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2018-05-14 14:45:01 UTC
Size:
2.04 KB
patch
obsolete
>From 6fac7206ec8e86d940e360188ec0f95390787ff3 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatetsolutions.com> >Date: Thu, 10 May 2018 08:12:04 -0400 >Subject: [PATCH] Bug 20724: Correctly mark an hold as waiting - > ReservesNeedReturns >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >We need to call Koha::Hold->set_waiting to correctly >calculate the expiration date. > >It fixes a regression introduced by > commit 26634151dbce0bf39ff6c9eda5b58bb993996a2d > Bug 12063 - Fix QA failures > >The expiration date has to be set for waiting holds > >== Test plan (time to execute: less than 4min) == >1. Set ReservesNeedReturns to "Don't automatically" >2. Place a hold on a specific item >3. Check it in and confirm hold >4. The hold should have an expiration date > record page â Hold â "Expiration" column >5. It should be listed in staff:/cgi-bin/koha/circ/waitingreserves.pl >6. Set ReservesNeedReturns to "Automatically" >7. Place a hold on a specific item > (which should also behave like we check the item in to > keep it for the patron) >8. The hold should have an *empty* expiration date > record page â Hold â "Expiration" column >9. Holds awaiting pickup page should crash > staff:/cgi-bin/koha/circ/waitingreserves.pl >10. Cancel the hold to remove the corrupted data > record page â Hold â the red X >11. Apply this patch >12. Place a hold on a specific item >13. The hold should have an expiration date (not empty) >14. It should be listed in staff:/cgi-bin/koha/circ/waitingreserves.pl >15. Celebrate! > >Signed-off-by: Victor Grousset <victor.grousset@biblibre.com> >--- > C4/Reserves.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 73b86b6..a919f75 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -203,6 +203,7 @@ sub AddReserve { > itemtype => $itemtype, > } > )->store(); >+ $hold->set_waiting() if $found eq 'W'; > > logaction( 'HOLDS', 'CREATE', $hold->id, Dumper($hold->unblessed) ) > if C4::Context->preference('HoldsLog'); >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20724
:
75211
|
75219
|
75221
|
75222
|
75223
|
75307
|
75308
|
75309
|
75325
|
75363
|
75364
|
75365
|
75366
|
75367