Attachment 75604 Details for Bug 3886 – Bug 3886: Fix mismatch of required permissions for printing slips

[patch] Bug 3886: Fix mismatch of required permissions for printing slips

Bug-3886-Fix-mismatch-of-required-permissions-for-.patch (text/plain), 2.53 KB, created by Jonathan Druart on 2018-05-28 19:51:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-05-28 19:51:51 UTC

Size: 2.53 KB

patch

obsolete

>From c33e73310d2f042e91d0ac52a2654173fc49070e Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Wed, 16 May 2018 02:45:02 +0200
>Subject: [PATCH] Bug 3886: Fix mismatch of required permissions for printing
> slips
>
>- Print summary (summary-print.pl)
>- Print quick slip (printslip.pl)
>- Print slip (printslip.pl)
>- Print overdues (print_overdues.pl)
>
>Perl scripts all require circulate_remaining_permissions, while
>in the template we were checking for edit_borrowers.
>
>Now the print pull down will only be visible if the patron has
>circulate or circulate_remaining_permissions.
>
>To test:
>- Verify that printing the listed slips works for staff users
>  with either circulate or circulate_remaining_permissions
>  and without edit_borrowers.
>
>Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc
>index 9b5524d4c1..1897af77ae 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc
>@@ -24,10 +24,11 @@
>         <a id="duplicate" class="btn btn-default btn-sm" href="/cgi-bin/koha/members/memberentry.pl?op=duplicate&amp;borrowernumber=[% patron.borrowernumber %]&amp;categorycode=[% patron.categorycode %]"><i class="fa fa-copy"></i> Duplicate</a>
>     [% END %]
> 
>+    [% IF CAN_user_circulate_circulate_remaining_permissions %]
>     <div class="btn-group">
>         <button class="btn btn-default btn-sm dropdown-toggle" data-toggle="dropdown"><i class="fa fa-print"></i> Print <span class="caret"></span></button>
>             <ul class="dropdown-menu">
>-                [% IF CAN_user_borrowers_edit_borrowers %]<li><a id="printsummary" href="#">Print summary</a></li>[% END %]
>+                <li><a id="printsummary" href="#">Print summary</a></li>
>                 <li><a id="printslip" href="#">Print slip</a></li>
>                 <li><a id="printquickslip" href="#">Print quick slip</a></li>
>                 [% IF Borrowers.HasOverdues( patron.borrowernumber ) %]
>@@ -35,6 +36,7 @@
>                 [% END %]
>             </ul>
>     </div>
>+    [% END %]
> 
>     [% IF ( CAN_user_reserveforothers ) %]
>         <a id="searchtohold" class="btn btn-default btn-sm" href="#"><i class="fa fa-search"></i> Search to hold</a>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 3886: 4167 | 75350 | 75568 | 75604