Attachment 7564 Details for Bug 7246 – Bug 7246 add offset/length and where options to rebuild_zebra

[patch] Bug 7246 add offset/length and where options to rebuild_zebra

Bug-7246-add-offsetlength-and-where-options-to-reb.patch (text/plain), 3.90 KB, created by Jared Camins-Esakov on 2012-02-10 15:15:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jared Camins-Esakov

Created: 2012-02-10 15:15:46 UTC

Size: 3.90 KB

patch

obsolete

>From ef40e78b04b8bf8130b8152aee16ec7c7ad7f525 Mon Sep 17 00:00:00 2001
>From: Paul Poulain <paul.poulain@biblibre.com>
>Date: Wed, 1 Feb 2012 15:15:02 +0100
>Subject: [PATCH] Bug 7246 add offset/length and where options to rebuild_zebra
>Content-Type: text/plain; charset="UTF-8"
>
>This patch reimplement a feature that is on biblibre/master for Koha-community/master
>
>It adds 4 parameters:
>* offset = the offset of record. Say 1000 to start rebuilding at the 1000th record of your database
>* length = how many records to export. Say 400 to export only 400 records
>* where = add a where clause to rebuild only a given itemtype, or anything you want to filter on
>
>Another improvement resulting from offset & length limit is the rebuild_zebra_sliced.zsh
>that will be submitted in another patch.
>rebuild_zebra_sliced will slice your all database in small chunks, and, if something went wrong for a given slice, will slice the slice, and repeat, until you reach a slice size of 1, showing which record is wrong in your database.
>
>Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
>Removed mention of -l option for limiting number of items exported, as requested
>by QA manager. This can be re-added in a later patch.
>---
> misc/migration_tools/rebuild_zebra.pl |   29 +++++++++++++++++++++++++----
> 1 files changed, 25 insertions(+), 4 deletions(-)
>
>diff --git a/misc/migration_tools/rebuild_zebra.pl b/misc/migration_tools/rebuild_zebra.pl
>index 31e8125..655b6d4 100755
>--- a/misc/migration_tools/rebuild_zebra.pl
>+++ b/misc/migration_tools/rebuild_zebra.pl
>@@ -34,6 +34,9 @@ my $want_help;
> my $as_xml;
> my $process_zebraqueue;
> my $do_not_clear_zebraqueue;
>+my $length;
>+my $where;
>+my $offset;
> my $verbose_logging = 0;
> my $zebraidx_log_opt = " -v none,fatal,warn ";
> my $result = GetOptions(
>@@ -51,7 +54,10 @@ my $result = GetOptions(
> 	'x'				=> \$as_xml,
>     'y'             => \$do_not_clear_zebraqueue,
>     'z'             => \$process_zebraqueue,
>-    'v+'            => \$verbose_logging,
>+    'where:s'        => \$where,
>+    'length:i'        => \$length,
>+    'offset:i'      => \$offset,
>+    'v+'             => \$verbose_logging,
> );
> 
> 
>@@ -294,13 +300,21 @@ sub select_all_records {
> }
> 
> sub select_all_authorities {
>-    my $sth = $dbh->prepare("SELECT authid FROM auth_header");
>+    my $strsth=qq{SELECT authid FROM auth_header};
>+    $strsth.=qq{ WHERE $where } if ($where);
>+    $strsth.=qq{ LIMIT $length } if ($length && !$offset);
>+    $strsth.=qq{ LIMIT $offset,$length } if ($length && $offset);
>+    my $sth = $dbh->prepare($strsth);
>     $sth->execute();
>     return $sth;
> }
> 
> sub select_all_biblios {
>-    my $sth = $dbh->prepare("SELECT biblionumber FROM biblioitems ORDER BY biblionumber");
>+    my $strsth = qq{ SELECT biblionumber FROM biblioitems };
>+    $strsth.=qq{ WHERE $where } if ($where);
>+    $strsth.=qq{ LIMIT $length } if ($length && !$offset);
>+    $strsth.=qq{ LIMIT $offset,$length } if ($offset);
>+    my $sth = $dbh->prepare($strsth);
>     $sth->execute();
>     return $sth;
> }
>@@ -639,7 +653,14 @@ Parameters:
>                             warnings and errors from the indexing are shown.
>                             Use log level 2 (-v -v) to include all Zebra logs.
> 
>-    -munge-config           Deprecated option to try
>+    --length   1234         how many biblio you want to export
>+    --offset 1243           offset you want to start to
>+                                example: --offset 500 --length=500 will result in a LIMIT 500,1000 (exporting 1000 records, starting by the 500th one)
>+                                note that the numbers are NOT related to biblionumber, that's the intended behaviour.
>+    --where                 let you specify a WHERE query, like itemtype='BOOK'
>+                            or something like that
>+
>+    --munge-config          Deprecated option to try
>                             to fix Zebra config files.
>     --help or -h            show this message.
> _USAGE_
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 7246: 6345 | 6347 | 6994 | 6995 | 7200 | 7379 | 7410 | 7470 | 7564