Bugzilla – Attachment 75830 Details for
Bug 20073
Move Elasticsearch settings to configuration files
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20073: Remove perlcritic error
Bug-20073-Remove-perlcritic-error.patch (text/plain), 1.33 KB, created by
Kyle M Hall (khall)
on 2018-06-05 18:20:09 UTC
(
hide
)
Description:
Bug 20073: Remove perlcritic error
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2018-06-05 18:20:09 UTC
Size:
1.33 KB
patch
obsolete
>From 5ce03635894fd054dee3d358fa24fb0187399cd3 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 23 Apr 2018 15:12:20 -0300 >Subject: [PATCH] Bug 20073: Remove perlcritic error > >"return" statement with explicit "undef" at line 245, column 5. See >page 199 of PBP. (Severity: 5) > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > Koha/SearchEngine/Elasticsearch.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/SearchEngine/Elasticsearch.pm b/Koha/SearchEngine/Elasticsearch.pm >index e90af21711..0b33c06b3b 100644 >--- a/Koha/SearchEngine/Elasticsearch.pm >+++ b/Koha/SearchEngine/Elasticsearch.pm >@@ -165,7 +165,7 @@ sub get_elasticsearch_mappings { > if (!defined $all_mappings{$self->index}) { > $sort_fields{$self->index} = {}; > my $mappings = { >- data => _get_elasticsearch_mapping('general', '') >+ data => scalar _get_elasticsearch_mapping('general', '') > }; > my $marcflavour = lc C4::Context->preference('marcflavour'); > $self->_foreach_mapping( >@@ -242,7 +242,7 @@ sub _get_elasticsearch_mapping { > if (defined $settings->{$purpose}{'default'}) { > return $settings->{$purpose}{'default'}; > } >- return undef; >+ return; > } > > sub reset_elasticsearch_mappings { >-- >2.15.1 (Apple Git-101)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20073
:
70827
|
70836
|
70837
|
73054
|
73138
|
73144
|
73383
|
74420
|
74421
|
74759
|
75438
|
75453
|
75829
| 75830 |
75831
|
76315
|
76520