Attachment 75886 Details for Bug 16653 – Bug 16653: Display number of checkouts when exporting 'Most-circulated items' as CSV

[patch] Bug 16653: Display number of checkouts when exporting 'Most-circulated items' as CSV

Bug-16653-Display-number-of-checkouts-when-exporti.patch (text/plain), 2.46 KB, created by Jonathan Druart on 2018-06-07 14:49:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-06-07 14:49:09 UTC

Size: 2.46 KB

patch

obsolete

>From 1e1d7467fa399d58129633de92e99bf6f0652619 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 7 Jun 2018 11:47:46 -0300
>Subject: [PATCH] Bug 16653: Display number of checkouts when exporting
> 'Most-circulated items' as CSV
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>reports/cat_issues_top.pl does not export "Count of checkouts" column as CSV
>
>To replicate:
>
>1/ Make sure that test instance has circulation in a given date range
>2/ Go to Home âº Reports âº Most-circulated items
>3/ Select a date range
>4/ Select 'To screen into the browser' radio button, click submit.
>5/ Note that Columns 'Rank/Biblioitemnumbers', 'Global' and 'Count of checkouts' appear in screen output.
>6/ Click the browser's back button
>7/ Change output to 'To a file', click submit.
>
>Without this patch:
>the columns "100/", "Global" and "Total" are exported to the CSV file.
>"100/" contains the rank, "Global" is still global, and the "Total" column is empty.
>
>With this patch patch applied, the last column is filled and the "Total" line is removed
>
>(This script is really dirty)
>---
> reports/cat_issues_top.pl | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
>diff --git a/reports/cat_issues_top.pl b/reports/cat_issues_top.pl
>index e7a315f588..c7a974bd03 100755
>--- a/reports/cat_issues_top.pl
>+++ b/reports/cat_issues_top.pl
>@@ -93,17 +93,10 @@ if ($do_it) {
>             print $line->{rowtitle}.$sep;
>             foreach my $cell (@$x) {
>                 print $cell->{value}.$sep;
>+                print $cell->{count};
>             }
>-            print $line->{totalrow};
>             print "\n";
>         }
>-# footer
>-        print "TOTAL";
>-        $cols = @$results[0]->{loopfooter};
>-        foreach my $col ( @$cols ) {
>-            print $sep.$col->{totalcol};
>-        }
>-        print $sep.@$results[0]->{total};
>         exit;
>     }
> # Displaying choices
>@@ -163,7 +156,6 @@ output_html_with_http_headers $input, $cookie, $template->output;
> sub calculate {
>     my ($line, $column, $filters) = @_;
>     my @mainloop;
>-    my @loopfooter;
>     my @loopcol;
>     my @loopline;
>     my @looprow;
>@@ -415,7 +407,6 @@ sub calculate {
>     $globalline{looprow} = \@looprow;
>     $globalline{loopcol} = \@loopcol;
> # 	# the foot (totals by borrower type)
>-    $globalline{loopfooter} = \@loopfooter;
>     $globalline{total}= $grantotal;
>     $globalline{line} = $line;
>     $globalline{column} = $column;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 16653: 75886 | 75937 | 76376 | 76377